fix: (slightly) performant href/isActive Link resolution during navigations by Sheraff · Pull Request #6880 · TanStack/router

Sheraff · 2026-03-10T13:55:33Z

No description provided.

…te changes

…ations

coderabbitai · 2026-03-10T13:56:02Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9cc3761b-d5b4-43bc-9c18-d398766e19f8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch refactor-signals-simple-link-href-active-optim

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-03-10T13:56:32Z

View your CI Pipeline Execution ↗ for commit 0869ed5

Command	Status	Duration	Result
`nx affected --targets=test:eslint,test:unit,tes...`	✅ Succeeded	11m 47s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	2m 1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-03-10 21:35:42 UTC

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 53310eaa94

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

packages/router-core/src/stores.ts

github-actions · 2026-03-10T14:00:20Z

Bundle Size Benchmarks

Commit: 7706e3f54020
Measured at: 2026-03-10T21:24:47.588Z
Baseline source: history:dadf7e9d9d01
Dashboard: bundle-size history

Scenario	Current (gzip)	Delta vs baseline	Raw	Brotli	Trend
`react-router.minimal`	87.85 KiB	+777 B (+0.87%)	276.94 KiB	76.32 KiB	▁▁▁▁▁▁▂▂▃▃▃█
`react-router.full`	91.07 KiB	+1,019 B (+1.10%)	287.69 KiB	79.21 KiB	▁▁▁▁▁▁▂▂▂▂▂█
`solid-router.minimal`	35.24 KiB	-1.18 KiB (-3.25%)	106.49 KiB	31.63 KiB	▇▇▇▇▇▇▇████▁
`solid-router.full`	39.66 KiB	-1.08 KiB (-2.66%)	119.77 KiB	35.59 KiB	▆▆▆▆▆▆▇▇███▁
`vue-router.minimal`	53.20 KiB	+936 B (+1.75%)	152.66 KiB	47.76 KiB	▁▁▁▁▁▁▂▂▂▂▃█
`vue-router.full`	58.22 KiB	+1.15 KiB (+2.01%)	168.64 KiB	52.06 KiB	▁▁▁▁▁▁▂▂▂▂▂█
`react-start.minimal`	100.50 KiB	+864 B (+0.85%)	316.13 KiB	86.97 KiB	▁▁▁▁▁▁▂▂▂▂▃█
`react-start.full`	103.91 KiB	+961 B (+0.91%)	326.37 KiB	89.83 KiB	▁▁▁▁▁▁▂▂▂▂▂█
`solid-start.minimal`	47.58 KiB	-1.17 KiB (-2.40%)	144.13 KiB	42.12 KiB	▆▆▆▆▆▆▇▇███▁
`solid-start.full`	53.18 KiB	-1.03 KiB (-1.90%)	160.32 KiB	46.81 KiB	▆▆▆▆▆▆▇▇███▁

Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.

pkg-pr-new · 2026-03-10T14:01:21Z

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@6880

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@6880

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@6880

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@6880

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@6880

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@6880

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@6880

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@6880

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@6880

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@6880

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@6880

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@6880

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@6880

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@6880

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@6880

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@6880

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@6880

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@6880

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@6880

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@6880

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@6880

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@6880

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@6880

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@6880

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@6880

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@6880

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@6880

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@6880

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@6880

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@6880

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@6880

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@6880

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@6880

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@6880

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@6880

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@6880

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@6880

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@6880

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@6880

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@6880

commit: cf54728

codspeed-hq · 2026-03-10T14:15:29Z

Merging this PR will degrade performance by 27.2%

⚠️

Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
❌ 2 regressed benchmarks
✅ 3 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	`client-side navigation loop (react)`	54.5 ms	42.1 ms	+29.28%
❌	`client-side navigation loop (solid)`	63.8 ms	80 ms	-20.24%
❌	`client-side navigation loop (vue)`	42 ms	57.7 ms	-27.2%

_{Comparing refactor-signals-simple-link-href-active-optim (0869ed5) with refactor-signals (4a35572)}

Sheraff added 3 commits March 10, 2026 09:55

fix(solid-router,vue-router): rebuild inherited link locations on rou…

e4761a2

…te changes

slightly better solid link perf

1b44f8c

fix: (slightly) performant href/isActive Link resolution during navig…

53310ea

…ations

github-actions bot added package: react-router package: router-core package: solid-router package: vue-router labels Mar 10, 2026

ci: apply automated fixes

7de3ee4

chatgpt-codex-connector bot reviewed Mar 10, 2026

View reviewed changes

packages/router-core/src/stores.ts Outdated Show resolved Hide resolved

Sheraff and others added 9 commits March 10, 2026 16:10

typo

26de2c3

ci: apply automated fixes

f1c129e

preload uses location already built for href/active

e9c45b7

ci: apply automated fixes

b069f66

fix

43117ee

lint

983501e

empty

21c78e4

how about just location?

3ec0c8e

cleanup, should be good now

0869ed5

Sheraff merged commit ab32d92 into refactor-signals Mar 10, 2026
14 of 15 checks passed

Sheraff deleted the refactor-signals-simple-link-href-active-optim branch March 10, 2026 21:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: (slightly) performant href/isActive Link resolution during navigations#6880

fix: (slightly) performant href/isActive Link resolution during navigations#6880
Sheraff merged 13 commits intorefactor-signalsfrom
refactor-signals-simple-link-href-active-optim

Sheraff commented Mar 10, 2026

Uh oh!

coderabbitai bot commented Mar 10, 2026 •

edited

Loading

Review skipped

Uh oh!

nx-cloud bot commented Mar 10, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

github-actions bot commented Mar 10, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Mar 10, 2026 •

edited

Loading

Uh oh!

codspeed-hq bot commented Mar 10, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

Sheraff commented Mar 10, 2026

Uh oh!

coderabbitai bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

nx-cloud bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

github-actions bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Size Benchmarks

Uh oh!

pkg-pr-new bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed-hq bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will degrade performance by 27.2%

Performance Changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

coderabbitai bot commented Mar 10, 2026 •

edited

Loading

nx-cloud bot commented Mar 10, 2026 •

edited

Loading

github-actions bot commented Mar 10, 2026 •

edited

Loading

pkg-pr-new bot commented Mar 10, 2026 •

edited

Loading

codspeed-hq bot commented Mar 10, 2026 •

edited

Loading