fix(start): align Rsbuild SSR asset URLs for css?url imports#7590
fix(start): align Rsbuild SSR asset URLs for css?url imports#7590SyMind wants to merge 8 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughRsbuild planning now builds client, server, and provider asset paths through shared helpers. The e2e app adds a ChangesRsbuild asset URL alignment
E2E example page styling
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thank you very much for such a quick fix! |
|
View your CI Pipeline Execution ↗ for commit 6a81ee8
☁️ Nx Cloud last updated this comment at |
Merging this PR will regress 4 benchmarks
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Memory | mem server error-paths not-found (react) |
266.6 KB | 884.8 KB | -69.86% |
| ❌ | Memory | mem server error-paths redirect (vue) |
299.9 KB | 396.3 KB | -24.32% |
| ❌ | Memory | mem server server-fn-churn (react) |
270.9 KB | 282 KB | -3.94% |
| ❌ | Simulation | client-route-tree-scale navigation loop (react) |
74 ms | 77 ms | -3.84% |
| ⚡ | Memory | mem server peak-large-page (react) |
2,184.3 KB | 955 KB | ×2.3 |
| ⚡ | Memory | mem server error-paths not-found (solid) |
763 KB | 422.7 KB | +80.5% |
| ⚡ | Memory | mem server peak-large-page (solid) |
1,386.8 KB | 772.5 KB | +79.53% |
| ⚡ | Memory | mem server serialization-payload (react) |
5.2 MB | 3.4 MB | +52.19% |
| ⚡ | Simulation | client-loaders navigation loop (react) |
55.5 ms | 52.8 ms | +5.17% |
| ⚡ | Memory | mem server server-fn-churn (vue) |
273.7 KB | 264.1 KB | +3.66% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing SyMind:fix-rsbuild-inline-css (6a81ee8) with main (07ce903)
There was a problem hiding this comment.
Nx Cloud has identified a possible root cause for your failed CI:
We investigated the tanstack-vue-start-e2e-basic:test:e2e--vite-prerender failure and determined it is unrelated to this PR's changes. The error references a missing isPrerender export in a Vue e2e utility module that our diff does not touch, and the project itself is not among the affected projects. We are classifying this as an environment state issue — likely a stale build artifact — rather than a regression introduced by this PR.
No code changes were suggested for this issue.
You can trigger a rerun by pushing an empty commit:
git commit --allow-empty -m "chore: trigger rerun"
git push
🎓 Learn more about Self-Healing CI on nx.dev
Fix #7543
css?urlimports resolve to client-served asset URLs.rsc-rsbuilde2e route that imports a stylesheet with?urland verifies the actual element style is applied.rsc-rsbuildfixture homepage and node_modules client component page to match the main RSC fixture’s server/client visual style.Summary by CodeRabbit
?urlimports so server-rendered pages load the same public assets as the client.?url(including injection into the document head).?urlstyles.*.css?urlimports.