Skip to content

Default dashboard flag #2055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mbeaulne merged 1 commit into from
Apr 10, 2026
Merged

Default dashboard flag #2055

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 19 additions & 22 deletions src/routes/router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
Outlet,
redirect,
} from "@tanstack/react-router";
import { createElement } from "react";

import { ErrorPage } from "@/components/shared/ErrorPage";
import { AuthorizationResultScreen as GitHubAuthorizationResultScreen } from "@/components/shared/GitHubAuth/AuthorizationResultScreen";
Expand Down Expand Up @@ -47,15 +48,14 @@ export const RUNS_BASE_PATH = "/runs";
export const QUICK_START_PATH = "/quick-start";
const SETTINGS_PATH = "/settings";
const IMPORT_PATH = "/app/editor/import-pipeline";
const DASHBOARD_PATH = "/dashboard";
Copy link
Copy Markdown

@Ark-kun Ark-kun Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>/pipelines - My Pipelines
>/components - Components
>/favorites - Favorites
>/recently-viewed - Recently Viewed
Is it possible to limit the number of root route prefixes? having so many prefixes makes it very hard to route backend and frontend. Especially in local and HuggingFace deployments.

Can we put as much as possible under "/app"?

export const APP_ROUTES = {
HOME: "/",
DASHBOARD: DASHBOARD_PATH,
DASHBOARD_RUNS: `${DASHBOARD_PATH}/runs`,
DASHBOARD_PIPELINES: `${DASHBOARD_PATH}/pipelines`,
DASHBOARD_COMPONENTS: `${DASHBOARD_PATH}/components`,
DASHBOARD_FAVORITES: `${DASHBOARD_PATH}/favorites`,
DASHBOARD_RECENTLY_VIEWED: `${DASHBOARD_PATH}/recently-viewed`,
DASHBOARD: "/",
DASHBOARD_RUNS: "/runs",
DASHBOARD_PIPELINES: "/pipelines",
DASHBOARD_COMPONENTS: "/components",
DASHBOARD_FAVORITES: "/favorites",
DASHBOARD_RECENTLY_VIEWED: "/recently-viewed",
QUICK_START: QUICK_START_PATH,
IMPORT: IMPORT_PATH,
PIPELINE_EDITOR: `${EDITOR_PATH}/$name`,
Expand Down Expand Up @@ -85,27 +85,25 @@ const mainLayout = createRoute({
component: RootLayout,
});

const indexRoute = createRoute({
getParentRoute: () => mainLayout,
path: APP_ROUTES.HOME,
component: Home,
});

// Dashboard is a pathless layout — its children resolve to top-level paths
// (/, /runs, /pipelines, etc.) without a /dashboard prefix.
// When the dashboard flag is off, the layout is a passthrough and / renders Home.
const dashboardRoute = createRoute({
id: "dashboard-layout",
getParentRoute: () => mainLayout,
path: APP_ROUTES.DASHBOARD,
component: DashboardLayout,
beforeLoad: () => {
if (!isFlagEnabled("dashboard")) {
throw redirect({ to: APP_ROUTES.HOME });
}
},
component: () =>
isFlagEnabled("dashboard")
? createElement(DashboardLayout)
: createElement(Outlet),
});

const dashboardIndexRoute = createRoute({
getParentRoute: () => dashboardRoute,
path: "/",
component: DashboardHomeView,
component: () =>
isFlagEnabled("dashboard")
? createElement(DashboardHomeView)
: createElement(Home),
});

const dashboardRunsRoute = createRoute({
Expand Down Expand Up @@ -264,7 +262,6 @@ const dashboardRouteTree = dashboardRoute.addChildren([
]);

const appRouteTree = mainLayout.addChildren([
indexRoute,
dashboardRouteTree,
quickStartRoute,
settingsRouteTree,
Expand Down
Loading