Skip to content

remove old home page #2056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mbeaulne wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove old home page #2056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/components/Home/PipelineSection/index.ts
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/components/Home/RunSection/index.ts
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions src/components/Home/index.ts
View file
Open in desktop

This file was deleted.

10 changes: 9 additions & 1 deletion src/components/layout/RootLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,15 @@ import AppMenu from "./AppMenu";
const RootLayout = () => {
useDocumentTitle();
const { pathname } = useLocation();
const isDashboard = pathname.startsWith("/dashboard");
// Dashboard routes handle their own footer in the sidebar.
// Only show AppFooter on non-dashboard routes (editor, runs, settings, etc.)
const isDashboard =
pathname === "/" ||
pathname.startsWith("/runs") ||
pathname.startsWith("/pipelines") ||
pathname.startsWith("/components") ||
pathname.startsWith("/favorites") ||
pathname.startsWith("/recently-viewed");

return (
<BackendProvider>
Expand Down
11 changes: 0 additions & 11 deletions src/components/shared/Settings/useFlags.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,6 @@ import type { BetaFlagsStorage } from "./types";

const storage = getStorage<keyof BetaFlagsStorage, BetaFlagsStorage>();

/**
* Non-hook flag check for use outside React (e.g., route beforeLoad).
*/
export function isFlagEnabled(flagName: keyof typeof ExistingFlags): boolean {
return (
storage.getItem("betaFlags")?.[flagName] ??
ExistingFlags[flagName]?.default ??
false
);
}

export function useFlags() {
return {
getFlags: () => storage.getItem("betaFlags"),
Expand Down
7 changes: 0 additions & 7 deletions src/flags.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,4 @@ export const ExistingFlags: ConfigFlags = {
category: "beta",
},

["dashboard"]: {
name: "Dashboard",
description:
"Enable the new Dashboard page, a redesigned homepage experience.",
default: false,
category: "beta",
},
};
51 changes: 0 additions & 51 deletions src/routes/Home/Home.tsx
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion src/routes/Home/index.ts
View file
Open in desktop

This file was deleted.

14 changes: 2 additions & 12 deletions src/routes/router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,13 @@ import {
Outlet,
redirect,
} from "@tanstack/react-router";
import { createElement } from "react";

import { ErrorPage } from "@/components/shared/ErrorPage";
import { AuthorizationResultScreen as GitHubAuthorizationResultScreen } from "@/components/shared/GitHubAuth/AuthorizationResultScreen";
import { AuthorizationResultScreen as HuggingFaceAuthorizationResultScreen } from "@/components/shared/HuggingFaceAuth/AuthorizationResultScreen";
import { AddSecretView } from "@/components/shared/SecretsManagement/components/AddSecretView";
import { ReplaceSecretView } from "@/components/shared/SecretsManagement/components/ReplaceSecretView";
import { SecretsListView } from "@/components/shared/SecretsManagement/components/SecretsListView";
import { isFlagEnabled } from "@/components/shared/Settings/useFlags";
import { BASE_URL, IS_GITHUB_PAGES } from "@/utils/constants";

import RootLayout from "../components/layout/RootLayout";
Expand All @@ -26,7 +24,6 @@ import { DashboardPipelinesView } from "./Dashboard/DashboardPipelinesView";
import { DashboardRecentlyViewedView } from "./Dashboard/DashboardRecentlyViewedView";
import { DashboardRunsView } from "./Dashboard/DashboardRunsView";
import Editor from "./Editor";
import Home from "./Home";
import { ImportPage } from "./Import";
import NotFoundPage from "./NotFoundPage";
import PipelineRun from "./PipelineRun";
Expand Down Expand Up @@ -87,23 +84,16 @@ const mainLayout = createRoute({

// Dashboard is a pathless layout — its children resolve to top-level paths
// (/, /runs, /pipelines, etc.) without a /dashboard prefix.
// When the dashboard flag is off, the layout is a passthrough and / renders Home.
const dashboardRoute = createRoute({
id: "dashboard-layout",
getParentRoute: () => mainLayout,
component: () =>
isFlagEnabled("dashboard")
? createElement(DashboardLayout)
: createElement(Outlet),
component: DashboardLayout,
});

const dashboardIndexRoute = createRoute({
getParentRoute: () => dashboardRoute,
path: "/",
component: () =>
isFlagEnabled("dashboard")
? createElement(DashboardHomeView)
: createElement(Home),
component: DashboardHomeView,
});

const dashboardRunsRoute = createRoute({
Expand Down
Loading