chore: Set transaction isolation level to be SERIALIZABLE#198
Open
yuechao-qin wants to merge 1 commit intomasterfrom
Open
chore: Set transaction isolation level to be SERIALIZABLE#198yuechao-qin wants to merge 1 commit intomasterfrom
SERIALIZABLE#198yuechao-qin wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Closes https://github.com/Shopify/oasis-frontend/issues/524
Added SERIALIZABLE transaction isolation level to have a clear error if multiple backfills are happening at the same time.
What changed?
Modified the
migrate_dbfunction to set the transaction isolation level to SERIALIZABLE when running annotation backfills. This ensures that if multiple backfill operations attempt to run simultaneously, a transaction error will be thrown to prevent conflicts.How to test?
Why make this change?
Previously, during a backfill there was a
Duplicate KEY errorwhich was ambiguous why this error occurred. Adding this isolation level will give better troubleshooting message what's happening if multiple backfills are happening.