Adding a photon vision estimator based vision io.#628
Merged
stephenjust merged 7 commits intomainfrom Feb 21, 2026
Merged
Conversation
pwbriggs
force-pushed
the
saqib/using-photon-vision-estimator
branch
2 times, most recently
from
9d0933c to
5720801
Compare
pwbriggs
force-pushed
the
saqib/using-photon-vision-estimator
branch
from
5720801 to
1786d8a
Compare
stephenjust
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are we doing this?
To follow closer to the conventions that photonlib proscribes in their example java code:
https://github.com/PhotonVision/photonvision/blob/main/photonlib-java-examples/poseest/src/main/java/frc/robot/Vision.java
Whats changing?
How we calculate the pose estimations including the photon pose estimator to use the lowest ambiguity selector based on readings being pulled from the estimator.
Questions/notes for reviewers
This needs a basic test, but eventually we also need to include the ability to tune using a std dev matrix.
This is just being put up in case anyone wants to review for the time being.
How this was tested