fix :malformed utl::warn call in detailed_route#9694
Merged
maliberty merged 3 commits intoThe-OpenROAD-Project:masterfrom Mar 9, 2026
Merged
fix :malformed utl::warn call in detailed_route#9694maliberty merged 3 commits intoThe-OpenROAD-Project:masterfrom
maliberty merged 3 commits intoThe-OpenROAD-Project:masterfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
suhr25
force-pushed
the
fix/drt-droute-end-iter-warn-args
branch
from
95b460a to
6e00058
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
…lamp utl::warn requires 3 args (module, code, msg). The warn call when -droute_end_iter > 64 was missing DRT and the message ID, causing a Tcl wrong-number-of-args error instead of a warning. Signed-off-by: suhr25 <suhridmarwah07@gmail.com> Signed-off-by: Suhrid Marwah <suhridmarwah07@gmail.com>
Signed-off-by: suhr25 <suhridmarwah07@gmail.com> Signed-off-by: Suhrid Marwah <suhridmarwah07@gmail.com>
Signed-off-by: Suhrid Marwah <suhridmarwah07@gmail.com>
suhr25
force-pushed
the
fix/drt-droute-end-iter-warn-args
branch
from
6e00058 to
694474c
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
Hi @eder-matheus @maliberty, |
maliberty
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes a malformed
utl::warncall indetailed_routethat caused a Tcl argument error when-droute_end_iterwas set above64. Instead of stopping with an error, the command now correctly prints a warning and clamps the value.FIX
utl::warncall was missing the required module and code arguments.DRTand warning code518to match the logger API.Before
utl::warn "-droute_end_iter cannot be greater than 64. Setting -droute_end_iter to 64."After
utl::warn DRT 518 "-droute_end_iter cannot be greater than 64. Setting -droute_end_iter to 64."VERIFICATION
Run:
Before: Tcl error due to wrong
utl::warnusage.After: Warning is printed, value is clamped to
64, and routing continues.