Skip to content

Update area.py#14307

Open
kvadrik wants to merge 9 commits intoTheAlgorithms:masterfrom
kvadrik:master
Open

Update area.py#14307
kvadrik wants to merge 9 commits intoTheAlgorithms:masterfrom
kvadrik:master

Conversation

@kvadrik
Copy link

@kvadrik kvadrik commented Feb 24, 2026

Describe your change:

I have added the lateral surface area calculation for a cylinder and a cone.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Feb 24, 2026
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Feb 24, 2026
kvadrik and others added 2 commits February 24, 2026 23:34
@kvadrik
Update area.py
6bbdd98 
Added functions for cone and cylinder lateral surface areas
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
4fefa5b 
for more information, see https://pre-commit.ci
@kvadrik kvadrik closed this Feb 24, 2026
@kvadrik kvadrik reopened this Feb 24, 2026
@kvadrik
refactor: remove unnecessary empty iterable in deque (RUF037)
fcdf5f1 
Clean up trailing whitespace and empty list in deque initialization to satisfy Ruff linting rules.
@kvadrik
style: update jump_search to use PEP 695 type parameters
ca2306d 
Updated the jump_search function signature to use the Python 3.12+ generic type parameter syntax [T]. This resolves the UP047 linting error flagged by Ruff.
@kvadrik
style: update valid_input to use Python 3.12 type parameters
64e413c 
Applied PEP 695 syntax to the valid_input function by moving the 'num' generic into brackets. This resolves the UP047 error in the machine_learning directory.
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Feb 24, 2026
@kvadrik
fix(types): add Comparable bound to jump_search type parameter
97b6607 
Updated the PEP 695 type parameter syntax to include the 'Comparable' bound. This resolves the Mypy error regarding unsupported left operand types for the '<' operator, ensuring that the generic type T supports comparisons.
@kvadrik kvadrik requested a review from mindaugl February 24, 2026 22:35
@kvadrik
Extra empty space removal
c9a3ddd 
Removed an extra empty line at the end of the file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mindaugl mindaugl Awaiting requested review from mindaugl

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kvadrik @mindaugl