Code review fixes for 5 oldest code files#14566
Open
JiayangLai wants to merge 1 commit intoTheAlgorithms:masterfrom
Open
Code review fixes for 5 oldest code files#14566JiayangLai wants to merge 1 commit intoTheAlgorithms:masterfrom
JiayangLai wants to merge 1 commit intoTheAlgorithms:masterfrom
Conversation
- sentinel_linear_search.py: Add return type annotation, fix input mutation bug by creating a copy instead of modifying the original sequence - double_linear_search.py: Add empty array handling to prevent IndexError - alternate_disjoint_set.py: Fix type hint (list -> list[int]), remove unused max_set attribute - double_linear_search_recursion.py: Fix mutable default argument bug by using None as default and initializing inside the function - remove_duplicate.py: Clarify docstring to accurately describe behavior (output is sorted, not in original order) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Code review and fixes for the 5 oldest Python files in the repository (based on last modification date):
searches/sentinel_linear_search.py (last modified: 2020-03-04)
int | None)data_structures/disjoint_set/alternate_disjoint_set.py (last modified: 2020-08-28)
listtolist[int]max_setattributesearches/double_linear_search_recursion.py (last modified: 2020-09-18)
right: int = 0->right: int | None = None)searches/double_linear_search.py (last modified: 2020-09-23)
strings/remove_duplicate.py (last modified: 2020-09-24)
Test plan
All doctests pass:
python -m doctest searches/sentinel_linear_search.pypython -m doctest searches/double_linear_search.pypython -m doctest searches/double_linear_search_recursion.pypython -m doctest strings/remove_duplicate.py🤖 Generated with Claude Code