RES-1863: draggable map for group location fine-tuning#895
Open
edwh wants to merge 1 commit into
Open
Conversation
Re-implements the intent of the stale RES-1862_draggable_map branch on the current codebase (which already gained a static location map and Places autocomplete since that branch was written). The Mapbox geocoder switch bundled into the old branch is deliberately NOT included - that is RES-1858's concern. - GroupLocationMap becomes draggable: the marker is pinned to the map centre, dragging emits update:lat/update:lng, and a fresh geocode from the location field still recentres the map (with an epsilon guard so the parent echoing our own drag back down doesn't fight the user) - GroupAddEdit syncs the dragged coordinates and sends lat/lng with create/edit; the :id remount hack is gone (it would have destroyed and recreated the map on every drag) - API v2 group create/update accept optional lat/lng, which take precedence over the server-side geocode of the location text; country still comes from geocoding (or the existing record when the location text is unchanged). With an explicit pin, an ungeocodable location string is no longer fatal - the pin wins and country is left null - New partials.dragmap hint (en/fr/fr-BE) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TzY1phBjyT3HogpeS53zon
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-implements #637 (RES-1863, draggable map for group create/edit) from scratch on the current codebase. The old branch was 1,240 commits behind and conflicted with the build system; it also bundled the Mapbox geocoder switch, which belongs to RES-1858 (#644) and is deliberately not included here.
Since #637 was written,
developgained a staticGroupLocationMappreview and Google Places autocomplete, so this PR is much smaller than the original:GroupLocationMapbecomes draggable: the marker is pinned to the map centre; dragging emitsupdate:lat/update:lng. A fresh geocode from the location field still recentres the map, with an epsilon guard so the parent echoing a drag back down doesn't fight the user. Apartials.dragmaphint invites the fine-tune.GroupAddEditsyncs the dragged coordinates and includeslat/lngin the create/edit payloads (string-cast — the store's FormData builder drops falsy values, which would eat a 0 coordinate). The:id-based remount hack is removed; it would have destroyed the map on every drag.POST /groupsandPATCH /groups/{id}accept optionallat/lng(validated numeric, in range, both-or-neither), which take precedence over the server-side geocode of the location text. Country still comes from geocoding, or from the existing record when the location text is unchanged. With an explicit pin, an ungeocodable location string is no longer fatal — the pin wins and the country is left null.Testing
GroupLatLngOverrideTest(6 tests): client coordinates win on create and edit; geocode fallback unchanged without them; out-of-range rejected; ungeocodable-location-with-pin succeeds; unchanged-location edit keeps existing coords.GroupLocationMap.test.js(5 tests): drag emits updates, marker follows, external geocode recentres, echo-guard, hint text.