Improve GS io tracing for TTIGW & LBS LNS protocols#7859
Merged
Conversation
dc5edba to
3250d23
Compare
Contributor
Author
|
I've also improved the recording of the errors in the spans. One more thing to note, this only improves otel traces, but there is no runtime tracing in here. Should we add runtime tracing too? |
johanstokking
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve Gateway Server io tracing for TTIGW and LBS LNS (Semtech WebSocket) protocols by adding OpenTelemetry spans to key connection and message handling operations.
Changes
HandleConnection,HandleUpMessage,HandleDownMessageinpkg/gatewayserver/io/ttigw/ttigw.go.HandleConnectionInfo,HandleTraffic,HandleUpMessage,HandleDownMessageinpkg/gatewayserver/io/semtechws/ws.go.otrace.NewNoopTracerProvider()withnoop.NewTracerProvider()inpkg/telemetry/tracing/tracing.go.Testing
Steps
Results
Spans should appear for each connection lifecycle and message exchange, with error recording on failures.
Regressions
None.
Notes for Reviewers
None.
Checklist
README.mdfor the chosen target branch.CHANGELOG.md.CONTRIBUTING.md, there are no fixup commits left.