chore: improve naming of the testing functionality#2084
Merged
triceo merged 2 commits intoTimefoldAI:mainfrom Feb 9, 2026
Merged
chore: improve naming of the testing functionality#2084triceo merged 2 commits intoTimefoldAI:mainfrom
triceo merged 2 commits intoTimefoldAI:mainfrom
Conversation
triceo
requested review from
Christopher-Chianelli and
TomCools
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the naming of testing functionality in the preview API by renaming "MoveRunner/NeighborhoodEvaluator" to "MoveTester/NeighborhoodTester" to better reflect their purpose as testing utilities. The PR also upgrades the environment mode from PHASE_ASSERT to FULL_ASSERT for more comprehensive testing assertions.
Changes:
- Renamed
MoveRunnertoMoveTesterandMoveRunContexttoMoveTestContext - Renamed
NeighborhoodEvaluatortoNeighborhoodTesterandNeighborhoodEvaluationContexttoNeighborhoodTestContext - Updated all implementation classes, tests, and documentation to use the new naming consistently
Reviewed changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs/src/modules/ROOT/pages/optimization-algorithms/neighborhoods.adoc | Updated documentation to use new naming conventions (MoveTester, NeighborhoodTester) throughout |
| core/src/test/java/ai/timefold/solver/core/preview/api/neighborhood/NeighborhoodTesterTest.java | Renamed test class and updated all references to use NeighborhoodTester |
| core/src/test/java/ai/timefold/solver/core/preview/api/move/builtin/*.java | Updated all move-related tests to use MoveTester instead of MoveRunner |
| core/src/test/java/ai/timefold/solver/core/preview/api/move/MoveTesterTest.java | Renamed test class from MoveRunnerTest to MoveTesterTest |
| core/src/test/java/ai/timefold/solver/core/impl/**/*.java | Updated implementation tests to use new naming |
| core/src/main/java/ai/timefold/solver/core/preview/api/neighborhood/*.java | Renamed API interfaces and updated documentation |
| core/src/main/java/ai/timefold/solver/core/preview/api/move/*.java | Renamed API interfaces and updated documentation |
| core/src/main/java/ai/timefold/solver/core/impl/neighborhood/*.java | Renamed implementation classes to match new API naming |
| core/src/main/java/ai/timefold/solver/core/impl/move/*.java | Renamed implementation classes and upgraded to FULL_ASSERT mode |
docs/src/modules/ROOT/pages/optimization-algorithms/neighborhoods.adoc
Outdated
Show resolved
Hide resolved
|
Christopher-Chianelli
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.