Conversation
There was a problem hiding this comment.
Pull request overview
This pull request refactors the testing utilities by removing the timefold-solver-test module and consolidating all testing utilities into the core module. The test-related classes are moved from ai.timefold.solver.test.* packages to new locations within ai.timefold.solver.core.*, specifically using .test sub-packages to denote testing utilities.
Changes:
- Removed the entire
tools/testmodule including its POM, source files, and build configurations - Moved
ConstraintVerifierand related classes fromtest.api.score.streamtocore.api.score.stream.test - Moved
MockProblemChangeDirectorfromtest.api.solver.changetocore.api.solver.change - Moved
MoveTesterandNeighborhoodTesterfrom preview API packages to.testsub-packages - Updated all import statements across Spring and Quarkus integrations to reference the new package locations
- Removed documentation references to the
timefold-solver-testdependency - Updated TODO.md to track this architectural change for release notes
Reviewed changes
Copilot reviewed 93 out of 93 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/test/pom.xml | Deleted entire test module and its Maven configuration |
| tools/test/src/test/resources/logback-test.xml | Removed test logging configuration |
| tools/test/src/build/revapi-*.json | Removed API compatibility check configurations |
| tools/pom.xml | Removed test module reference from parent POM |
| tools/migration/pom.xml | Removed timefold-solver-test dependency |
| spring-integration/spring-boot-autoconfigure/pom.xml | Removed optional test dependency |
| spring-integration/spring-boot-autoconfigure/src/main/java/ai/timefold/solver/spring/boot/autoconfigure/TimefoldSolverBeanFactory.java | Updated imports to core.api.score.stream.test package |
| spring-integration/spring-boot-autoconfigure/src/test/java/.../Timefold*Test.java | Updated test imports to new package locations |
| quarkus-integration/quarkus/deployment/pom.xml | Removed test dependency |
| quarkus-integration/quarkus/deployment/src/main/java/.../TimefoldProcessor.java | Updated class reference to core.impl.score.stream.test |
| quarkus-integration/quarkus/deployment/src/main/java/.../DotNames.java | Updated to import ConstraintVerifier directly instead of using string |
| quarkus-integration/quarkus/deployment/src/test/java/.../TimefoldConstraintVerifierTest.java | Updated test imports |
| quarkus-integration/quarkus-benchmark/deployment/pom.xml | Removed test dependency |
| docs/src/modules/ROOT/pages/quickstart/*.adoc | Removed instructions to add timefold-solver-test dependency |
| docs/src/modules/ROOT/pages/quickstart/shared/constrainttests.adoc | Changed "Then" to "Now" for better flow |
| docs/src/modules/ROOT/pages/constraints-and-score/score-calculation.adoc | Removed reference to adding test dependency |
| docs/TODO.md | Added items tracking the test module removal for release notes |
| core/src/test/java/ai/timefold/solver/core/testdomain/constraintverifier/*.java | Moved test domain classes from test package to core.testdomain.constraintverifier |
| core/src/test/java/ai/timefold/solver/core/preview/api/*/test/*Test.java | Updated package declarations and imports for test classes |
| core/src/test/java/ai/timefold/solver/core/impl/score/stream/test/*Test.java | Updated package and imports for constraint stream tests |
| core/src/test/java/ai/timefold/solver/core/impl/domain/variable/*Test.java | Updated MoveTester imports |
| core/src/test/java/ai/timefold/solver/core/impl/neighborhood/NeighborhoodsTest.java | Updated NeighborhoodTester import |
| core/src/test/java/ai/timefold/solver/core/api/solver/change/MockProblemChangeDirectorTest.java | Moved from test package to core.api.solver.change and updated imports/code style |
| core/src/main/java/ai/timefold/solver/core/preview/api/neighborhood/test/*.java | Moved NeighborhoodTester and related classes to test sub-package |
| core/src/main/java/ai/timefold/solver/core/preview/api/neighborhood/MoveProvider.java | Added import for NeighborhoodTester in new location |
| core/src/main/java/ai/timefold/solver/core/preview/api/move/test/*.java | Moved MoveTester and related classes to test sub-package |
| core/src/main/java/ai/timefold/solver/core/preview/api/move/Move.java | Added import for MoveTester in new location |
| core/src/main/java/ai/timefold/solver/core/impl/score/stream/test/*.java | Moved constraint verifier implementation classes from test module to core impl |
| core/src/main/java/ai/timefold/solver/core/impl/score/stream/common/inliner/ConstraintMatchSupplier.java | Split long line for better code formatting |
| core/src/main/java/ai/timefold/solver/core/impl/neighborhood/*.java | Updated imports for test utilities |
| core/src/main/java/ai/timefold/solver/core/impl/move/*.java | Updated imports for MoveTester utilities |
| core/src/main/java/ai/timefold/solver/core/api/solver/change/ProblemChangeDirector.java | Added @see reference to MockProblemChangeDirector |
| core/src/main/java/ai/timefold/solver/core/api/solver/change/MockProblemChangeDirector.java | Moved from test module, updated package, cleaned up annotations, and improved documentation |
| core/src/main/java/ai/timefold/solver/core/api/score/stream/test/*.java | Moved public API interfaces from test module to core API |
| core/src/main/java/ai/timefold/solver/core/api/score/analysis/MatchAnalysis.java | Fixed typo: "requre" → "require" |
| core/src/main/java/ai/timefold/solver/core/api/score/ScoreExplanation.java | Split long comment line for better formatting |
| build/bom/pom.xml | Removed timefold-solver-test artifact entries from BOM |
core/src/main/java/ai/timefold/solver/core/api/score/analysis/ConstraintAnalysis.java
Outdated
Show resolved
Hide resolved
core/src/main/java/ai/timefold/solver/core/api/score/analysis/MatchAnalysis.java
Outdated
Show resolved
Hide resolved
docs/src/modules/ROOT/pages/quickstart/quarkus/quarkus-quickstart.adoc
Outdated
Show resolved
Hide resolved
...odules/ROOT/pages/quickstart/quarkus-vehicle-routing/quarkus-vehicle-routing-quickstart.adoc
Show resolved
Hide resolved
zepfred
left a comment
There was a problem hiding this comment.
LGTM!
Please merge only after confirming there is no use of the old package naming in the documentation.
|



No description provided.