-
Notifications
You must be signed in to change notification settings - Fork 181
fix: module info setup #2158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix: module info setup #2158
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
70f4af2
fix: JPMS add missing kopt "opens"
TomCools d619a5d
fix: JPMS restructured dependency graph
TomCools f1eb8e2
fix: widen quarkus deployment exports.
TomCools a8ae8b7
fix: revert friendly imports
TomCools e5af872
fix: slight module-info fixes
TomCools 9a25608
fix: add docs
TomCools 5635c07
Update quarkus-integration/quarkus/runtime/src/main/java/module-info.…
TomCools dd9d9d3
Update docs/src/modules/ROOT/pages/integration/integration.adoc
TomCools 68e3ec7
Update core/src/main/java/module-info.java
TomCools 1af37df
Update docs/src/modules/ROOT/pages/integration/integration.adoc
TomCools df254f7
Update docs/src/modules/ROOT/pages/integration/integration.adoc
TomCools 4e7d4d6
fix: correct module-info
TomCools File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,14 @@ | ||
| module ai.timefold.solver.jackson { | ||
|
|
||
| exports ai.timefold.solver.jackson.api; | ||
|
|
||
| provides tools.jackson.databind.JacksonModule with | ||
| ai.timefold.solver.jackson.api.TimefoldJacksonModule; | ||
|
|
||
| requires ai.timefold.solver.core; | ||
| requires transitive ai.timefold.solver.core; | ||
| requires org.jspecify; | ||
| requires tools.jackson.databind; | ||
|
|
||
| uses tools.jackson.databind.JacksonModule; | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,8 @@ | ||
| module ai.timefold.solver.jaxb { | ||
|
|
||
| exports ai.timefold.solver.jaxb.api.score; | ||
|
|
||
| requires ai.timefold.solver.core; | ||
| requires transitive ai.timefold.solver.core; | ||
| requires jakarta.xml.bind; | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,8 @@ | ||
| module ai.timefold.solver.jpa { | ||
| requires jakarta.persistence; | ||
| requires ai.timefold.solver.core; | ||
|
|
||
| exports ai.timefold.solver.jpa.api.score; | ||
|
|
||
| requires transitive ai.timefold.solver.core; | ||
| requires jakarta.persistence; | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 1 addition & 2 deletions
3
quarkus-integration/quarkus-benchmark/integration-test/src/main/java/module-info.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 6 additions & 2 deletions
8
quarkus-integration/quarkus-jackson/deployment/src/main/java/module-info.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,10 @@ | ||
| module ai.timefold.solver.quarkus.jackson.deployment { | ||
|
|
||
| exports ai.timefold.solver.quarkus.jackson.deployment; | ||
|
|
||
TomCools marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| requires transitive ai.timefold.solver.quarkus.jackson; | ||
| requires quarkus.core; | ||
| requires quarkus.core.deployment; | ||
| requires quarkus.jackson.spi; | ||
| requires ai.timefold.solver.quarkus.jackson; | ||
| requires quarkus.core; | ||
|
|
||
| } | ||
4 changes: 3 additions & 1 deletion
4
quarkus-integration/quarkus-jackson/integration-test/src/main/java/module-info.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,8 @@ | ||
| module ai.timefold.solver.quarkus.jackson.integration.test { | ||
| requires ai.timefold.solver.core; | ||
|
|
||
| requires ai.timefold.solver.quarkus.jackson; | ||
| requires jakarta.inject; | ||
| requires jakarta.ws.rs; | ||
| requires org.jspecify; | ||
|
|
||
| } |
4 changes: 3 additions & 1 deletion
4
quarkus-integration/quarkus-jackson/runtime/src/main/java/module-info.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,9 @@ | ||
| module ai.timefold.solver.quarkus.jackson { | ||
|
|
||
| exports ai.timefold.solver.quarkus.jackson; | ||
|
|
||
| requires ai.timefold.solver.core; | ||
| requires transitive ai.timefold.solver.core; | ||
| requires com.fasterxml.jackson.databind; | ||
| requires org.jspecify; | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 3 additions & 1 deletion
4
quarkus-integration/quarkus/devui-integration-test/src/main/java/module-info.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,6 @@ | ||
| module ai.timefold.solver.quarkus.devui.integration.test { | ||
| requires ai.timefold.solver.core; | ||
|
|
||
| requires ai.timefold.solver.quarkus; | ||
| requires org.jspecify; | ||
|
|
||
| } |
4 changes: 3 additions & 1 deletion
4
quarkus-integration/quarkus/integration-test/src/main/java/module-info.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,8 @@ | ||
| module ai.timefold.solver.quarkus.integration.test { | ||
| requires ai.timefold.solver.core; | ||
|
|
||
| requires ai.timefold.solver.quarkus; | ||
| requires jakarta.inject; | ||
| requires jakarta.ws.rs; | ||
| requires org.jspecify; | ||
|
|
||
| } |
4 changes: 3 additions & 1 deletion
4
quarkus-integration/quarkus/reflection-integration-test/src/main/java/module-info.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,8 @@ | ||
| module ai.timefold.solver.quarkus.reflection.integration.test { | ||
| requires ai.timefold.solver.core; | ||
|
|
||
| requires ai.timefold.solver.quarkus; | ||
| requires jakarta.inject; | ||
| requires jakarta.ws.rs; | ||
| requires org.jspecify; | ||
|
|
||
| } |
10 changes: 5 additions & 5 deletions
10
quarkus-integration/quarkus/runtime/src/main/java/module-info.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,21 @@ | ||
| module ai.timefold.solver.quarkus { | ||
|
|
||
| exports ai.timefold.solver.quarkus.bean; | ||
| exports ai.timefold.solver.quarkus; | ||
| exports ai.timefold.solver.quarkus.bean; | ||
| exports ai.timefold.solver.quarkus.config; | ||
| exports ai.timefold.solver.quarkus.devui; | ||
| exports ai.timefold.solver.quarkus.gizmo; | ||
|
|
||
| requires ai.timefold.solver.core; | ||
| requires transitive ai.timefold.solver.core; | ||
| requires arc; | ||
| requires io.smallrye.config; | ||
| requires io.vertx.core; | ||
| requires jakarta.cdi; | ||
| requires jakarta.inject; | ||
| requires org.eclipse.microprofile.config; | ||
| requires org.graalvm.nativeimage; | ||
| requires org.jboss.logging; | ||
| requires org.jspecify; | ||
| requires quarkus.core; | ||
| requires io.smallrye.config; | ||
| requires org.jboss.logging; | ||
| requires org.eclipse.microprofile.config; | ||
|
|
||
| } |
16 changes: 12 additions & 4 deletions
16
spring-integration/spring-boot-autoconfigure/src/main/java/module-info.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,22 @@ | ||
| module ai.timefold.solver.spring.boot.autoconfigure { | ||
| requires ai.timefold.solver.jackson; | ||
|
|
||
| exports ai.timefold.solver.spring.boot.autoconfigure; | ||
| exports ai.timefold.solver.spring.boot.autoconfigure.config; | ||
| exports ai.timefold.solver.spring.boot.autoconfigure.util; | ||
|
|
||
| opens ai.timefold.solver.spring.boot.autoconfigure; | ||
|
|
||
| requires static ai.timefold.solver.benchmark; | ||
| requires transitive ai.timefold.solver.core; | ||
| requires transitive ai.timefold.solver.jackson; | ||
| requires org.apache.commons.logging; | ||
| requires org.jspecify; | ||
| requires spring.beans; | ||
| requires spring.boot; | ||
| requires spring.boot.autoconfigure; | ||
| requires spring.boot.persistence; | ||
| requires spring.context; | ||
| requires spring.core; | ||
| requires tools.jackson.databind; | ||
| requires ai.timefold.solver.benchmark; | ||
| requires ai.timefold.solver.core; | ||
| requires org.jspecify; | ||
|
|
||
| } |
4 changes: 3 additions & 1 deletion
4
spring-integration/spring-boot-integration-test/src/main/java/module-info.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,9 @@ | ||
| module ai.timefold.solver.spring.boot.integration.test { | ||
| requires ai.timefold.solver.core; | ||
|
|
||
| requires ai.timefold.solver.spring.boot.starter; | ||
| requires org.jspecify; | ||
| requires spring.boot; | ||
| requires spring.boot.autoconfigure; | ||
| requires spring.web; | ||
|
|
||
| } |
2 changes: 1 addition & 1 deletion
2
spring-integration/spring-boot-starter/src/main/java/module-info.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| module ai.timefold.solver.spring.boot.starter { | ||
|
|
||
| requires ai.timefold.solver.spring.boot.autoconfigure; | ||
| requires transitive ai.timefold.solver.spring.boot.autoconfigure; | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.