Reorganize types and traits to deprioritize Vec streams#746
Open
frankmcsherry wants to merge 3 commits intoTimelyDataflow:masterfrom
Open
Reorganize types and traits to deprioritize Vec streams#746frankmcsherry wants to merge 3 commits intoTimelyDataflow:masterfrom
Vec streams#746frankmcsherry wants to merge 3 commits intoTimelyDataflow:masterfrom
Conversation
25ba925 to
ca2cd9f
Compare
ca2cd9f to
7697c6a
Compare
antiguru
approved these changes
Feb 23, 2026
Member
antiguru
left a comment
There was a problem hiding this comment.
Looks good! Mostly a cursory look, but nothing fundamentally wrong here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timely makes it easy, arguably too easy, to default to
Veccontainer streams. They are a fine default, but the software architecture should have them as an opinion layered atop a common core, rather than the core routing around their opinions.This PR attempts to deprioritize the vector-backed streams, renaming them
StreamVecand migrating their extension traits to avecmodule underoperators, a peer tocorerather than the default entry point. This is fairly disruptive, though there are pretty easy fixes in each case. Usually one can get what one wants by importing thevecflavored traits, though also using the core traits is not so bad with the.container::<Vec<_>>()annotation. Probably not how you want to start, but introducing the trade-off seems helpful.The documentation needs revision, and many comments are no longer accurate. Many references to
Streamstill exist,StreamCoreis still a thing, and tbd on just how terrible it looks to use. Much of the annotation annoyance comes from demo code that doesn't do anything, and the examples where something of consequence happens largely didn't need much change (the container types are clear, because nothing is so general that it works for all/many containers).