Skip to content

Conversation

@federicomassi
Copy link

Added yellow/golden/beer theme

Added yellow/golden/beer theme
@qwertyzen
Copy link

qwertyzen commented Dec 26, 2025

You have to also add an entry in theme_manager.py

class ThemeManager:
  _built_in_themes: List[str] = ["blue", "green", "dark-blue", "sweetkind"]

For it to work properly.

Nice theme BTW. Looks good. Added to my fork

@federicomassi
Copy link
Author

Ouch, you're right! Many thanks!

@FedericoSpada
Copy link
Collaborator

Hi,
It looks nice, but I have a few comments:

  • CTkButton\text_color_disabled in Light mode makes the text hard to read;
  • CTkComboBox and CtkEntry in Dark mode seem to follow a different color scheme: in other themes, it is always the same grey color. Maybe you can leave it in that way, or at least reuse one of the colors used for the other widgets;
  • More in general, some fg_color and bg_color have been chosen to have a yellow-ish vein, but if you compare blue.json and green.json, you can see that most of the time what changes is the primary color, with the background one always the same grey tone. I would follow the same concept;
  • You didn't follow the same spacing and new-line convention of the other JSON files: could you please update yours to be more uniform, so that they can be easily compared?

Finally, as suggested by qwertyzen, I would ask you to change "sweetkind" inside ThemeManager_built_in_themes to the name of your JSON file.
Since I've been given the Power, if you can make these changes, I'll merge your pull requests into the "develop" branch, and later into the main one.

@qwertyzen
Copy link

qwertyzen commented Jan 6, 2026

Hi @federicomassi

I completely agree with the suggestions of @FedericoSpada.

Suggestion: It would also be great if you would add another theme called "Red" or "Rose" with an appropriate red/pink primary color. I think that would really cover the primary colors - red+blue+green+yellow. Depends on what @FedericoSpada says.

@federicomassi
Copy link
Author

I am actually far from PC due to holidays, I agree and thank for all the suggestions.

The theme was made as a test for a visual themer app I made. I will correct it and I will add the main themes, plus the other suggested changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants