fix(state-machine): export the machine's initial context in the IR - #125
Merged
Conversation
IrExporter derived nothing for the initial context, so a generated runtime rebuilt it from the
schema via defaults. That is wrong for a field with a constrained default: a legislature enum
defaulting to "" fails its own OneOf, so every Reset()/initial snapshot lands invalid. The IR now
carries the actual StartsAt context (initialContext), which a generated machine uses verbatim.
Shape-only machines with an all-defaults initial (turnstile) just gain "initialContext":{}.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This PR is included in version 1.48.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IrExporter derived nothing for the initial context, so a generated runtime rebuilt it from the schema via defaults. That is wrong for a field with a constrained default: a legislature enum defaulting to "" fails its own OneOf, so every Reset()/initial snapshot lands invalid. The IR now carries the actual StartsAt context (initialContext), which a generated machine uses verbatim. Shape-only machines with an all-defaults initial (turnstile) just gain "initialContext":{}.