Skip to content

Reverted performance related improvement to clusters-dbscan that broke builds#3049

Merged
smallsaucepan merged 1 commit intoTurfjs:masterfrom
smallsaucepan:revert-kdbush-2885
Apr 18, 2026
Merged

Reverted performance related improvement to clusters-dbscan that broke builds#3049
smallsaucepan merged 1 commit intoTurfjs:masterfrom
smallsaucepan:revert-kdbush-2885

Conversation

@smallsaucepan
Copy link
Copy Markdown
Member

Reverted performance related improvement that was breaking builds. While faster, kdbush isn't released with a CJS variant and that caused dependency problems for users. Removes kdbush dependency and rolls back to using CJS compatible rbush 3.0.1.

Reverts #2885

Resolves #3018

Please provide the following when creating a PR:

  • Meaningful title, including the name of the package being modified.
  • Summary of the changes.
  • Heads up if this is a breaking change.
  • Any issues this resolves.
  • Inclusion of your details in the contributors field of package.json - you've earned it! 👏
  • Confirmation you've read the steps for preparing a pull request.

…ter, kdbush isn't released with a CJS variant and that caused dependency problems for users.
@mfedderly
Copy link
Copy Markdown
Collaborator

I think we should go ESM only for Turf 8 to simplify our own builds, so it would make sense to file a ticket to revert this in the 8 milestone. Consumers who are still using commonjs can use Node's --experimental-require-module if it isn't just enabled by default for them depending on version.

@smallsaucepan smallsaucepan merged commit fbfa6a7 into Turfjs:master Apr 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeScript build error in v7.3.2+: Module '"kdbush"' has no exported member 'KDBush'

2 participants