Reverted performance related improvement to clusters-dbscan that broke builds#3049
Merged
smallsaucepan merged 1 commit intoTurfjs:masterfrom Apr 18, 2026
Merged
Conversation
…ter, kdbush isn't released with a CJS variant and that caused dependency problems for users.
Collaborator
|
I think we should go ESM only for Turf 8 to simplify our own builds, so it would make sense to file a ticket to revert this in the 8 milestone. Consumers who are still using commonjs can use Node's |
mfedderly
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverted performance related improvement that was breaking builds. While faster, kdbush isn't released with a CJS variant and that caused dependency problems for users. Removes kdbush dependency and rolls back to using CJS compatible rbush 3.0.1.
Reverts #2885
Resolves #3018
Please provide the following when creating a PR:
contributorsfield ofpackage.json- you've earned it! 👏