-
-
Notifications
You must be signed in to change notification settings - Fork 718
refactor: simplify @tiptap/extension-link by inlining it to BlockNote #2623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nperez0111
wants to merge
10
commits into
main
Choose a base branch
from
feat/inline-tiptap-link
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ccb5c86
refactor: remove dep on @tiptap/extension-link and linkify
nperez0111 58f60d9
refactor: simplify inlined Link extension by removing unused tiptap o…
nperez0111 3c74322
refactor: simplify link API — move operations to StyleManager, rewrit…
nperez0111 ea7a515
fix: resolve lint errors in Link extension files
nperez0111 d79739a
fix: address CodeRabbit review feedback in linkDetector
nperez0111 ad191e6
chore: relax dependency version ranges and add workspaces config
nperez0111 89448b9
fix(ci): resolve duplicate React install and npm overrides conflict
nperez0111 e7ddc3c
Fixed lock file
matthewlipski 388d04c
fix: Non-editable link clicks opening duplicate tabs (#2667)
matthewlipski ddd42f8
feat: Link customization options (BLO-913) (#2666)
matthewlipski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we also make sure this is reflected correctly in blocknote initialization options?
Looking at it, that part is actually currently broken in docs: https://www.blocknotejs.org/docs/reference/editor/overview#options
(maybe check for other AutoTypeTables that are broken as well)