-
Notifications
You must be signed in to change notification settings - Fork 278
chore(ui5-toolbar): toolbar item wrapper introduced #12243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…nto poc-toolbar-item
|
|
||
| export default function ToolbarItemTemplate(this: ToolbarItem) { | ||
| return ( | ||
| <div onClick={this.onClick}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once we have a sample with different types of components we should test if this click only event handling is enough to manage the closing of the popover. If not we should extend it or think of another mehanism.
…nto poc-toolbar-item
|
🧹 Preview deployment cleaned up: https://pr-12243--ui5-webcomponents.netlify.app |
feat(ui5-toolbar-item): Refactor to a physical item for enhanced overflow logic
The
ui5-toolbar-itemhas been refactored from an abstract item to a physical item, enabling the transfer of logic foroverflowPriorityandpreventOverflowClosingdirectly to it.Key Enhancements:
ui5-toolbar-itemcan now wrap all types of components, allowing them to participate in the overflow toolbar logic seamlessly.expandInOverflowproperty.selfOverflowedproperty.This enhancement improves flexibility and ensures better integration of components within the overflow toolbar logic.