Skip to content

Conversation

@PetyaMarkovaBogdanova
Copy link
Contributor

@PetyaMarkovaBogdanova PetyaMarkovaBogdanova commented Sep 2, 2025

feat(ui5-toolbar-item): Refactor to a physical item for enhanced overflow logic

The ui5-toolbar-item has been refactored from an abstract item to a physical item, enabling the transfer of logic for overflowPriority and preventOverflowClosing directly to it.

Key Enhancements:

  • Universal Wrapping: The ui5-toolbar-item can now wrap all types of components, allowing them to participate in the overflow toolbar logic seamlessly.
  • Pre-defined Wrappers: For certain components, pre-defined wrappers are available. A console warning is displayed to encourage their use when applicable.
  • 100% Expansion in Overflow: Components that need to expand fully in the overflow popover can now implement the expandInOverflow property.
  • Self Overflow Logic: Components with internal overflow logic can implement the selfOverflowed property.

This enhancement improves flexibility and ensures better integration of components within the overflow toolbar logic.


export default function ToolbarItemTemplate(this: ToolbarItem) {
return (
<div onClick={this.onClick}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we have a sample with different types of components we should test if this click only event handling is enough to manage the closing of the popover. If not we should extend it or think of another mehanism.

@github-actions github-actions bot added the Stale label Oct 8, 2025
@github-actions github-actions bot removed the Stale label Oct 10, 2025
@github-actions github-actions bot added the Stale label Oct 31, 2025
@github-actions github-actions bot closed this Nov 7, 2025
@ui5-webcomponents-bot
Copy link
Collaborator

ui5-webcomponents-bot commented Nov 10, 2025

🧹 Preview deployment cleaned up: https://pr-12243--ui5-webcomponents.netlify.app

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 10, 2025 10:02 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 10, 2025 10:02 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 19, 2025 12:48 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 19, 2025 13:51 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 24, 2025 08:12 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 24, 2025 15:05 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview November 24, 2025 15:31 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 1, 2025 12:28 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 1, 2025 12:36 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 2, 2025 12:47 Inactive
@NakataCode NakataCode self-requested a review December 9, 2025 12:00
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 9, 2025 13:34 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 10, 2025 09:06 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview December 16, 2025 08:50 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants