fix(ui5-date-picker): Fix background vs foreground width mismatch.#13844
Open
sap-lh wants to merge 1 commit into
Open
fix(ui5-date-picker): Fix background vs foreground width mismatch.#13844sap-lh wants to merge 1 commit into
sap-lh wants to merge 1 commit into
Conversation
|
|
Added back a `width:100%` property that was removed in 89ccfb8. This property keeps the datepicker body width in sync with its background width. It might have been accidentally removed, since its counterpart in DateTimePicker.css is still used. Signed-off-by: Léo Hardt <leo.hardt@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi colleagues,
While updating our UI5 version, I noticed that some elements got 'glitched' out, and it's more apparent on dark mode.
I can verify that adding back the
width:100%property that was removed in 89ccfb8 resolves the issue. Notice that this property is still present in the DateTimePicker. It seems that its removal was not related entirely to the rest of the commit.Before


After
HTML description
ui5-date-pickerhas a full-wifth andbackground-color: var(--sapField_Background);property.ui5-datetime-input) does not have awidth:100%property anymore, so that this background is larger than the child element it is trying to cover.Regarding DTO, I work at SAP, but I will end the commit message with a sign-off regardless.
Thank you for your amazing work.
Thank you for your contribution! 👏
PR checklist
Check the Development Hints
Follow the Commit message Guidelines
For example:
fix(ui5-*): correct/fix sthorfeat(ui5-*): add/introduce sth. If you don't want the change to be part of the release changelog - usechore,refactorordocs.Add proper description about the background of the change and the change itself
Link to an existing issue (if available)
Use
Fixes: {#PR_NUMBER}to close the issue automatically when the PR is mergedor
Related to: {#PR_NUMBER}to just create a link between the PR and the issue.