Fix/animation noise #494
Open
Fix/animation noise #494
+141
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses two issues related to : 1. Noise and streaking artifacts in animations due to unconditional calls on every draw. 2. A caused by the keyword argument being passed to Matplotlib internals. The following changes have been made: - A flag has been introduced in the class to control when is called. - is now only called when the figure's layout is dirty, preventing unnecessary recalculations during animations. - The method in now only resizes the figure if the new size is different, preventing small oscillations. - The keyword argument is now popped in to prevent it from being passed to Matplotlib.
beckermr
requested changes
Jan 22, 2026
Collaborator
beckermr
left a comment
beckermr
left a comment
There was a problem hiding this comment.
Monkey patching is very fragile. Is there a cleaner way to do this?
Collaborator
Author
|
Well we would have to replace how the layout is drawn -- I believe the issue is coming from the fact that ultraplot does a lot of layout correction on draw which causes an issue with FuncAnimation. Another option would be to provide a |
Collaborator
|
I see. The less patching we do, the better. I think given the nature of the fix, we should try and solve this cleanly with the new layout handling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
animation.force_draw_idlercParam (default on) and uses it to gate a targeted FuncAnimation hook that swapsdraw_idleto full draws on interactive canvases, reducing backend redraw artifacts without affecting headless renders, while keeping the earlier layout convergence work intactCloses #488
Drafting for now as I am not happy with it yet.