refactor(editor): consolidate TypeSelector helpers and settings#144
Merged
Conversation
Move TypeSelectorHelpers to Types/ root and extract TypeUtility; group selector settings under Selectors/Settings/; drop dead API (TypeSelectorGlyphs, unused TypeExtensions members); fix nested-enum name parsing, lazy domain-type cache in GenericTypeResolver, tighten accessibility in SerializeReferenceRequiredGate; add EditMode tests. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NPBtcu7PX2VRkipKLVkinh
VPDPersonal
added
type: refactor
VPDPersonal
added
status: needs-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeSelectorHelpersfromTypes/Extensions/to theTypes/root and extract pure type-name utilities into a newTypeUtilityTypes/Selectors/Settings/(TypeSelectorSettings,TypeSelectorPreferences,TypeSelectorSettingsUI→TypeSelectorSettingsView)TypeSelectorConstraintResolveraround aResultstruct with a unified member lookupGenericTypeResolverbuild its domain-type cache lazilyTypeExtensions(split on the full nested-type path instead of a naive regex)TypeSelectorGlyphs, unusedTypeExtensionsmembers, redundant drawer plumbingpublic→internal) inSerializeReferenceRequiredGateand align editor extensions layoutTypeUtility,TypeSelectorHelpers, and the editorTypeExtensions(306 tests green)Notes for review
.metaGUIDs, so serialized references and USS bindings are unaffected; review renamed files with whitespace-aware diff.🇷🇺 Описание на русском
Кратко
TypeSelectorHelpersперенесён изTypes/Extensions/в кореньTypes/; чистые утилиты имён типов выделены в новыйTypeUtilityTypes/Selectors/Settings/(TypeSelectorSettings,TypeSelectorPreferences,TypeSelectorSettingsUI→TypeSelectorSettingsView)TypeSelectorConstraintResolverпереписан вокруг структурыResultс единым поиском членовGenericTypeResolverстроит кэш типов домена ленивоTypeExtensionsTypeSelectorGlyphs, неиспользуемые членыTypeExtensions, лишняя обвязка в drawer'ахpublic→internal) вSerializeReferenceRequiredGateTypeUtility,TypeSelectorHelpersи редакторскогоTypeExtensions(306 тестов зелёные)Замечания для ревью
.meta— сериализованные ссылки не затронуты; переименованные файлы удобнее смотреть diff'ом без учёта пробелов.