Fixed USE_STEAMWEBRTC using Native ICE Client instead of WebRTC#378
Open
ErrorAtLine0 wants to merge 1 commit intoValveSoftware:masterfrom
Open
Fixed USE_STEAMWEBRTC using Native ICE Client instead of WebRTC#378ErrorAtLine0 wants to merge 1 commit intoValveSoftware:masterfrom
ErrorAtLine0 wants to merge 1 commit intoValveSoftware:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issue where setting USE_STEAMWEBRTC in cmake doesn't actually use the WebRTC backend, but instead uses the native ICE client. This is what led to issue #247 occurring even when USE_STEAMWEBRTC is set.
Note that, after including this fix in a linux build, the flag ABSL_PROPAGATE_CXX_STD had to be set for test_p2p to compile.