push: add PushOnShutdown option to push metrics on shutdown #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #103 +/- ##
==========================================
- Coverage 87.58% 87.46% -0.12%
==========================================
Files 12 12
Lines 1643 1652 +9
==========================================
+ Hits 1439 1445 +6
- Misses 153 155 +2
- Partials 51 52 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This feature might be useful for processes with short lifetime, like CLI tools. For example, vmbackup process might finish before the first metrics reporting. With PushOnShutdown=true it would report metrics on Stop() call.
hagen1778
force-pushed
the
push-shutdown
branch
from
b4bf823 to
6e175c1
Compare
hagen1778
added a commit
to VictoriaMetrics/VictoriaMetrics
that referenced
this pull request
Sep 25, 2025
Push metrics on shutdown if `-pushmetrics.url` is configured. Before metrics reporting might have been skipped because of shutdown. Obsoletes VictoriaMetrics/metrics#103 Signed-off-by: hagen1778 <[email protected]>
Contributor
Author
|
Closing in favour of VictoriaMetrics/VictoriaMetrics#9767 |
f41gh7
pushed a commit
to VictoriaMetrics/VictoriaMetrics
that referenced
this pull request
Sep 30, 2025
Push metrics on shutdown if `-pushmetrics.url` is configured. Before metrics reporting might have been skipped because of shutdown. Obsoletes VictoriaMetrics/metrics#103 -------------- To test: 1. Run local VictoriaMetrics instance 2. Build and run vmbackup or vmrestore: ``` make vmbackup && ./bin/vmbackup -storageDataPath=victoria-metrics-data -snapshot.createURL="http://user:pass@localhost:8428/snapshot/create?authKey=foobar" -dst=fs:////vmbackup/dir -pushmetrics.url=http://localhost:8428/api/v1/import/prometheus,http://127.0.0.1:8428/api/v1/import/prometheus ``` 3. Try playing with `-pushmetrics.url` (good/bad/many addresses) and observe logs Related PR #9767
f41gh7
pushed a commit
to VictoriaMetrics/VictoriaMetrics
that referenced
this pull request
Sep 30, 2025
Push metrics on shutdown if `-pushmetrics.url` is configured. Before metrics reporting might have been skipped because of shutdown. Obsoletes VictoriaMetrics/metrics#103 -------------- To test: 1. Run local VictoriaMetrics instance 2. Build and run vmbackup or vmrestore: ``` make vmbackup && ./bin/vmbackup -storageDataPath=victoria-metrics-data -snapshot.createURL="http://user:pass@localhost:8428/snapshot/create?authKey=foobar" -dst=fs:////vmbackup/dir -pushmetrics.url=http://localhost:8428/api/v1/import/prometheus,http://127.0.0.1:8428/api/v1/import/prometheus ``` 3. Try playing with `-pushmetrics.url` (good/bad/many addresses) and observe logs Related PR #9767
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature might be useful for processes with short lifetime, like CLI tools. For example, vmbackup process might finish before the first metrics reporting. With PushOnShutdown=true it would report metrics on Stop() call.