vmagent,vmanomaly: fixed VPA and HPA naming and orphans cleanup - #2519
Merged
Conversation
AndrewChubatiuk
force-pushed
the
hpa-cleanup-fix
branch
from
August 20, 2026 05:46
227a954 to
dd3d31d
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
AndrewChubatiuk
force-pushed
the
hpa-cleanup-fix
branch
6 times, most recently
from
August 20, 2026 12:15
40b54d0 to
e6e36d8
Compare
vrutkovs
reviewed
Aug 21, 2026
| if !cr.Spec.DaemonSetMode { | ||
| objsToRemove = append(objsToRemove, &appsv1.DaemonSet{ObjectMeta: objMeta}) | ||
| } | ||
| // TODO: drop the cr.Name deletes below once enough time has passed since HPA/VPA objects |
Collaborator
There was a problem hiding this comment.
Lets add a specific deadline - i.e. 0.80 version
Contributor
Author
There was a problem hiding this comment.
done for both vmagent and vmanomaly
AndrewChubatiuk
force-pushed
the
hpa-cleanup-fix
branch
from
August 21, 2026 09:19
e6e36d8 to
de88d68
Compare
vrutkovs
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2518