Skip to content

Prevent duplicate publish.credentials and repositories.credentials from being saved to the config database#4257

Merged
Gedochao merged 1 commit intoVirtusLab:mainfrom
Gedochao:fix/config-duplicate-creds
May 9, 2026
Merged

Prevent duplicate publish.credentials and repositories.credentials from being saved to the config database#4257
Gedochao merged 1 commit intoVirtusLab:mainfrom
Gedochao:fix/config-duplicate-creds

Conversation

@Gedochao
Copy link
Copy Markdown
Contributor

@Gedochao Gedochao commented May 7, 2026

Fixes #4252

When a duplicate is passed to publish.credentials and repositories.credentials keys, a warning is printed and the duplicate is not actually saved.

[warn]: an identical publish.credentials entry for host a is already configured, a duplicate won't be saved.
Skipped saving config for key publish.credentials

Checklist

  • tested the solution locally and it works
  • ran the code formatter (scala-cli fmt .)
  • ran scalafix (./mill -i __.fix)

How much have your relied on LLM-based tools in this contribution?

extensively, Cursor + Claude

How was the solution tested?

Added new automated tests and ran them

@Gedochao Gedochao force-pushed the fix/config-duplicate-creds branch from ce87408 to d2ccce5 Compare May 7, 2026 09:10
@Gedochao Gedochao force-pushed the fix/config-duplicate-creds branch from d2ccce5 to 8eadb15 Compare May 7, 2026 09:18
@Gedochao Gedochao marked this pull request as ready for review May 8, 2026 06:41
@Gedochao Gedochao requested review from tgodzik and zielinsky May 8, 2026 06:42
@Gedochao Gedochao merged commit 97f6909 into VirtusLab:main May 9, 2026
209 of 230 checks passed
@Gedochao Gedochao deleted the fix/config-duplicate-creds branch May 9, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

publish.credentials config pollutes the config database with duplicates

2 participants