fix(core): normalize signed Rect border bounds - #2105
Merged
Conversation
xuefei1313
marked this pull request as ready for review
July 28, 2026 11:26
skie1997
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x1/y1fallback dimensions in attribute space while positioning paths from renderer-local coordinates.dxoffsets, and non-degenerate inner borders.Root cause
The border contribution assumed positive dimensions. For an
x/x1Rect with negative width, an outer-border expansion could invert the width and draw inside the physical bar. Itsx1/y1fallback also mixed attribute-space endpoints with renderer-local draw coordinates when offsets were applied.Validation
rushx test --runInBandinpackages/vrender-core— 613 passed, 3 skipped.rush compile -t @visactor/vrender-core.rush test --only tag:package— 7 related packages passed (existing warnings only).