Use effects for indirect call expressions#8625
Draft
stevenfontanella wants to merge 1 commit intoindirect-effects-sccfrom
Draft
Use effects for indirect call expressions#8625stevenfontanella wants to merge 1 commit intoindirect-effects-sccfrom
stevenfontanella wants to merge 1 commit intoindirect-effects-sccfrom
Conversation
stevenfontanella
force-pushed
the
expression-effects
branch
from
690ee8d to
75481a7
Compare
tlively
reviewed
Apr 20, 2026
| void visitCallIndirect(CallIndirect* curr) { | ||
| if (auto it = parent.module.typeEffects.find(curr->heapType); | ||
| it != parent.module.typeEffects.end()) { | ||
| parent.mergeIn(*it->second); |
Member
There was a problem hiding this comment.
It doesn't look like this accounts for the possible trap from a bad type check. I guess the previous code didn't need to handle it because setting calls implicitly includes trapping along with most other effects.
To make this as precise as possible, we could look at the type of the table and skip setting the trap effect if it is non-nullable and a subtype of the call_indirect expected type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.