Clarify 'alias outer' rules, add test#675
Open
lukewagner wants to merge 1 commit into
Open
Conversation
alexcrichton
approved these changes
Jul 1, 2026
Collaborator
|
FWIW the test doesn't currently pass in wasm-tools here, but that's for unrelated tooling issues where it looks like wasmprinter, when printing an invalid component, makes it invalid in a different way. Otherwise lgtm 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is meant to address the question in wasm-tools/#2545. Outer aliases were a bit hand-wavily defined before, so the PR tries to clarify things by ruling out more invalid cases in the grammar (which has been a source of confusion). Also a WAST test with better coverage is added (which passes on current Wasmtime).