feat: defer and source phase instance imports support#117
Open
guybedford wants to merge 1 commit intomainfrom
Open
feat: defer and source phase instance imports support#117guybedford wants to merge 1 commit intomainfrom
guybedford wants to merge 1 commit intomainfrom
Conversation
nicolo-ribaudo
approved these changes
Oct 24, 2025
Collaborator
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
This looks correct from the point of view of integrating with ECMA-262. I also personally like the proposed "syntax".
Is the idea that together with #116 I'd be able to do wasm-js:phase/source?foo=bar?
Collaborator
Author
Exactly, with this design both proposals could be used in conjunction with eachother in this way, without affecting the semantics of the other and aligning with JS semantics as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the final semantic gap for the ESM integration instance semantics, here's the initial spec for how Wasm instances may be able to import dependencies with phases in the
sourceordeferstage (both at implementation stage at TC39, with defer moving stabilization currently).The gist of it is that we use the import name value which is not necessary in these import use cases to instead indicate the phase
(import "foo" "wasm-js:phase/source" (global (ref extern)))or(import "foo" "wasm-js:phase/defer" (global (ref extern))).We can then obtain:
Reflect.getcall.WebAssembly.Moduleinstance as anexternfor the source phase for Wasm (and in due course for JS).Again we need to figure out if we want to use wasm-js here or just use wasm.