revert: SNP initial witness upload change#123
Closed
dirvine wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #122 after STG-01 showed it worsened the single-node path: failures rose to ~36% and moved to a client-side pre-payment
InsufficientPeersabort.Why
The #122 change made SNP quote collection stop after the first 7 witnessed quotes and then apply the paid-median voter quorum check. On the 30% NAT staging network this became stricter than the original node-side receiver gate: the client could reach and quote 7 peers, but aborted because the paid median issuer was not recognised by 5/7 selected witnesses.
This revert restores the prior rc-2026.6.2 client behaviour while the underlying node-side close-group/reachability divergence is investigated separately.
Verification
cargo test -p ant-core --lib data::client::quote -- --nocapturecargo check -p ant-corecargo fmt --all -- --checkgit diff --check