fix: use direct witness support for SNP median#124
Merged
Conversation
jacderida
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
voters_by_peer[median].len()), notselected_quote_issuers ∩ median_voters.Why
STG-01 showed #122 could abort before payment with:
The live transcript showed witnesses recognised the median issuer perfectly, but some recognised close peers were not direct responders. The old metric conflated “recognised by witnesses” with “recognised by selected quote issuers that are also witnesses”. This PR checks the intended property directly.
Target branch:
rc-2026.6.2.Verification
cargo test -p ant-core --lib data::client::quote -- --nocapture— 24 passedcargo check -p ant-corecargo clippy --all-targets --all-features -- -D warningscargo fmt --all -- --checkgit diff --check