feat(sdk): gRPC streaming download fan-out + Swift core gRPC client#197
Merged
Conversation
02537b9 to
c83d531
Compare
Adds streaming-download progress across all SDKs and the daemon:
- Daemon: gRPC oneof progress frames + REST NDJSON opt-in (Accept:
application/x-ndjson), plus a leading byte-total meta frame.
- SDKs: *_with_progress streaming methods returning a DownloadFrame
{Meta|Data|Progress} across the gRPC clients (10 SDKs) and REST (antd-js
+ all REST clients); existing byte-stream methods unchanged (additive).
- Swift gRPC core client completion.
Both transports verified end-to-end against a live daemon: smoothly-advancing
fetch progress (resolved -> fetching N/total) + byte-total denominator +
byte-for-byte reassembly.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
0bf0520 to
ca35076
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The gRPC counterpart to the REST streaming fan-out in #196 — adds
data_stream/data_stream_publicover gRPC to every SDK that ships a gRPC client:StreamRPC; idiomatic streaming return type per language. antd-js is REST-only (no gRPC client), so N/A.notImplemented()stubs (health / data / chunk / file get-put-cost + the two streaming methods) with a real implementation; regenerateddata.{pb,grpc}.swift; addsGrpcCoreTests.grpc_callconstructedAntdErrorwith positional/swapped args, so unmapped gRPC statuses raisedArgumentErrorinstead of a mappedAntdError. Corrected, plus aligned tests and the no-gem fallback shell.Validation
StreamRPC, supplied by the feat(antd): data streaming download — daemon wiring + REST SDK fan-out #196 base) viabuild.rsand passescargo fmt --check.Notes
🤖 Generated with Claude Code