-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Inserter: Allow parent/ancestor filtering by block variation name #73828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ockham
wants to merge
2
commits into
trunk
Choose a base branch
from
update/inserter-to-allow-parent-and-ancestor-filtering-by-block-variation-name
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Inserter: Allow parent/ancestor filtering by block variation name #73828
ockham
wants to merge
2
commits into
trunk
from
update/inserter-to-allow-parent-and-ancestor-filtering-by-block-variation-name
+39
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +52 B (0%) Total Size: 2.57 MB
ℹ️ View Unchanged
|
ockham
commented
Dec 9, 2025
Comment on lines
+1668
to
+1670
| // TODO: Compare block variation name to parent/ancestor list. | ||
| // Problem: For template parts that have been persisted to the DB, | ||
| // variation.name is prefixed with `instance_` (e.g. `instance_header`). |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See
| 'name' => 'instance_' . sanitize_title( $template_part->slug ), |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More context and rationale: #49500
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Block Variations
Block variations, including introducing new variations and variations as a feature
[Feature] Inserter
The main way to insert blocks using the + button in the editing interface
[Type] Experimental
Experimental feature or API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
WIP. Details to follow.
See #73724 (comment) for context.
Why?
TBD
How?
TBD
Testing Instructions
TBD
Screenshots or screencast
TODO
instance_andarea_prefix in Template Part block variations, see https://github.com/WordPress/gutenberg/pull/73828/files#r2602658280.getActiveBlockVariation()as part of the public API of@wordpress/blocks, consider extracting the non-state-dependent part of the function into a util that can be used by the@wordpress/block-editorpackage.