Skip to content

General: Ensure wp.template retains its Underscore dependency - #13217

Open
Sukhendu2002 wants to merge 2 commits into
WordPress:trunkfrom
Sukhendu2002:ticket/38052-wp-template-underscore
Open

General: Ensure wp.template retains its Underscore dependency#13217
Sukhendu2002 wants to merge 2 commits into
WordPress:trunkfrom
Sukhendu2002:ticket/38052-wp-template-underscore

Conversation

@Sukhendu2002

@Sukhendu2002 Sukhendu2002 commented Aug 21, 2026

Copy link
Copy Markdown

Trac ticket: https://core.trac.wordpress.org/ticket/38052

What this PR does

Captures the Underscore instance when wp-util initializes. This prevents lazy wp.template() compilation from using a global _ later replaced by Lodash or another script.

Also adds a QUnit regression test that replaces global _ after initialization and confirms template rendering still works.

Use of AI Tools

AI assistance: Yes
Tool(s): pi
Model(s): GPT-5.6
Used for: Code review; final implementation and tests were reviewed and edited by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@Sukhendu2002
Sukhendu2002 marked this pull request as ready for review August 21, 2026 10:41
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sukhendu2002.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant