Skip to content

Fix the order of the buttons in the Customizer Menus panel. #13228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
afercia wants to merge 1 commit into from
+12 −13
Closed

Fix the order of the buttons in the Customizer Menus panel. #13228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/wp-admin/css/customize-controls.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2493,6 +2493,7 @@ body.cheatin p {
* Widgets and Menus common styles
*/

.customize-control-nav_menu-buttons,
.customize-control-widgets-buttons {
display: flex;
flex-wrap: wrap;
Expand Down
4 changes: 0 additions & 4 deletions src/wp-admin/css/customize-nav-menus.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -860,10 +860,6 @@ li.assigned-to-menu-location .add-new-menu-item {
}

.customize-control-nav_menu .customize-control-nav_menu-buttons {
display: flex;
flex-direction: row-reverse;
align-items: center;
gap: 8px;
margin-top: 12px;
}

Expand Down
6 changes: 3 additions & 3 deletions src/wp-includes/customize/class-wp-customize-nav-menu-control.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,13 @@ public function content_template() {
?>
</p>
<div class="customize-control-nav_menu-buttons">
<button type="button" class="button add-new-menu-item" aria-label="<?php esc_attr_e( 'Add or remove menu items' ); ?>" aria-expanded="false" aria-controls="available-menu-items">
<?php echo $add_items; ?>
</button>
<button type="button" class="button-link reorder-toggle" aria-label="<?php esc_attr_e( 'Reorder menu items' ); ?>" aria-describedby="reorder-items-desc-{{ data.menu_id }}">
<span class="reorder"><?php _e( 'Reorder' ); ?></span>
<span class="reorder-done"><?php _e( 'Done' ); ?></span>
</button>
<button type="button" class="button add-new-menu-item" aria-label="<?php esc_attr_e( 'Add or remove menu items' ); ?>" aria-expanded="false" aria-controls="available-menu-items">
<?php echo $add_items; ?>
</button>
</div>
<p class="screen-reader-text" id="reorder-items-desc-{{ data.menu_id }}">
<?php
Expand Down
14 changes: 8 additions & 6 deletions tests/qunit/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,12 +254,14 @@ <h3 class="accordion-section-title" tabindex="0">

<!-- Templates for Customizer Menus -->
<script type="text/html" id="tmpl-customize-control-nav_menu-content">
<button type="button" class="button add-new-menu-item" aria-label="Add or remove menu items" aria-expanded="false" aria-controls="available-menu-items">
Add Items </button>
<button type="button" class="not-a-button reorder-toggle" aria-label="Reorder menu items" aria-describedby="reorder-items-desc-{{ data.menu_id }}">
<span class="reorder">Reorder</span>
<span class="reorder-done">Done</span>
</button>
<div class="customize-control-nav_menu-buttons">
<button type="button" class="button-link reorder-toggle" aria-label="Reorder menu items" aria-describedby="reorder-items-desc-242">
<span class="reorder">Reorder</span>
<span class="reorder-done">Done</span>
</button>
<button type="button" class="button add-new-menu-item" aria-label="Add or remove menu items" aria-expanded="false" aria-controls="available-menu-items">
Add Items </button>
</div>
<p class="screen-reader-text" id="reorder-items-desc-{{ data.menu_id }}">When in reorder mode, additional controls to reorder menu items will be available in the items list above.</p>
<span class="add-menu-item-loading spinner"></span>
<span class="menu-delete-item">
Expand Down
Loading