Blocks: Process shortcodes in pattern blocks - #13261
Draft
jawsrdev wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/58397
What?
When a
core/patternblock is used in a block template, template-level shortcode processing runs before the pattern is expanded. Shortcodes introduced by the pattern therefore remain unprocessed and are rendered literally.This change applies
shortcode_unautop()anddo_shortcode()to registered pattern content beforedo_blocks()renders its blocks.Why?
Processing shortcodes before blocks matches the existing block-template ordering and also allows block markup returned by a shortcode to be rendered.
Testing
A PHPUnit regression test registers a shortcode and a pattern containing a
core/shortcodeblock, renders the pattern through the same shortcode-then-block ordering used by block templates, and verifies the shortcode output.Focused command:
The focused test was not run locally because the available environment does not include PHP or Docker. This is submitted as a draft so CI and contributor testing can validate it before review.
Use of AI Tools
AI assistance: Yes
Tool(s): OpenAI Codex in ChatGPT Work
Model(s): GPT-5
Used for: Investigating the rendering order, drafting the implementation and regression test, reviewing the diff for scope and consistency, and preparing this pull request description. PHPUnit was not available in the working environment, as disclosed above.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.