Skip to content

WP_Site::get_instance() fatals when the cached value is not an object #13270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
josephscott wants to merge 3 commits into
base: trunk
Choose a base branch
from
+7 −1
Open

WP_Site::get_instance() fatals when the cached value is not an object #13270

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0898b6a
WP_Site::get_instance() fatals when the cached value is not an object
josephscott Aug 25, 2026
57bd2fe
Update src/wp-includes/class-wp-site.php
josephscott Aug 26, 2026
fdf9bef
Merge branch 'trunk' into 65962/wp-site-get-instance-cache-check
josephscott Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/wp-includes/class-wp-site.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ final class WP_Site {
* Retrieves a site from the database by its ID.
*
* @since 4.5.0
* @since 7.2.0 Non-object cache values are now treated as a cache miss.
*
* @global wpdb $wpdb WordPress database abstraction object.
*
Expand All @@ -175,7 +176,12 @@ public static function get_instance( $site_id ) {

$_site = wp_cache_get( $site_id, 'sites' );

if ( false === $_site ) {
// A cached -1 records a previous lookup that found nothing. Anything else that is not a site object is treated as a cache miss.
if (
( ! is_object( $_site ) || ! isset( $_site->blog_id ) )
&&
! is_numeric( $_site )
) {
$_site = $wpdb->get_row( $wpdb->prepare( "SELECT * FROM {$wpdb->blogs} WHERE blog_id = %d LIMIT 1", $site_id ) );

if ( empty( $_site ) || is_wp_error( $_site ) ) {
Comment thread
westonruter marked this conversation as resolved.
Expand Down
Loading