Fix Snoopy stream timeout handling - #13276
Closed
arshidkv12 wants to merge 1 commit into
Closed
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
SergeyBiryukov
approved these changes
Aug 26, 2026
pento
pushed a commit
that referenced
this pull request
Aug 26, 2026
…brary. `socket_set_timeout()` is an alias of `stream_set_timeout()`, and is deprecated in PHP 8.5. Includes removing unnecessary `unset( $postdata )` call before `$postdata` is assigned. Reference: [https://wiki.php.net/rfc/deprecations_php_8_5#formally_deprecate_socket_set_timeout PHP RFC: Deprecations for PHP 8.5: Formally deprecate socket_set_timeout]. Developed in #13276. Props arshidkv12. Fixes #65965. git-svn-id: https://develop.svn.wordpress.org/trunk@63350 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Aug 26, 2026
…brary. `socket_set_timeout()` is an alias of `stream_set_timeout()`, and is deprecated in PHP 8.5. Includes removing unnecessary `unset( $postdata )` call before `$postdata` is assigned. Reference: [https://wiki.php.net/rfc/deprecations_php_8_5#formally_deprecate_socket_set_timeout PHP RFC: Deprecations for PHP 8.5: Formally deprecate socket_set_timeout]. Developed in WordPress/wordpress-develop#13276. Props arshidkv12. Fixes #65965. Built from https://develop.svn.wordpress.org/trunk@63350 git-svn-id: http://core.svn.wordpress.org/trunk@62543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
nathanrice
pushed a commit
to nathanrice/wordpress-develop
that referenced
this pull request
Aug 26, 2026
…brary. `socket_set_timeout()` is an alias of `stream_set_timeout()`, and is deprecated in PHP 8.5. Includes removing unnecessary `unset( $postdata )` call before `$postdata` is assigned. Reference: [https://wiki.php.net/rfc/deprecations_php_8_5#formally_deprecate_socket_set_timeout PHP RFC: Deprecations for PHP 8.5: Formally deprecate socket_set_timeout]. Developed in WordPress#13276. Props arshidkv12. Fixes #65965. git-svn-id: https://develop.svn.wordpress.org/trunk@63350 602fd350-edb4-49c9-b593-d223f7449a82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the deprecated
socket_set_timeout()function withstream_set_timeout()inclass-snoopy.php.Also removes the unnecessary
unset( $postdata )before$postdatais assigned.Changes
socket_set_timeout()withstream_set_timeout()for setting the read timeout.unset( $postdata )statement.Trac ticket: https://core.trac.wordpress.org/ticket/65965
Use of AI Tools
AI assistance: Yes
Tool(s): ChatGPT
Model(s): GPT-5.6 Luna
Used for: Improving the English in the ticket and pull request description.