[Website] Target temporary Playground in Import ZIP, Import from GitHub. Don't overwrite a saved site. #2990
+278
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamziel
changed the title
adamziel
commented
Dec 6, 2025
…ites When importing a ZIP file while viewing a saved site, the import now goes into a temporary Playground rather than overwriting the saved site. This protects saved sites from accidental data loss. The implementation stores the selected file, switches to an existing temporary site (or creates a new one), then completes the import via a useEffect once the switch is done. Two e2e tests verify this behavior: - Importing while on a saved site switches to temporary site first - Importing with no temporary site creates one before importing
adamziel
force-pushed
the
start-new-playground-before-importing-data
branch
3 times, most recently
from
018845c to
7381f45
Compare
The ZIP import tests were failing because after navigating the WordPress iframe to a marker page, the test was checking the body content immediately before navigation completed. Fixed by: - Using website.wordpress() instead of the wordpress fixture to get a fresh frame locator reference after navigation - Increasing the timeout to 30 seconds to allow for iframe navigation time
adamziel
force-pushed
the
start-new-playground-before-importing-data
branch
from
7381f45 to
f07c316
Compare
Replace 180+ lines of manual byte-by-byte ZIP file creation with the existing encodeZip and collectBytes utilities from @php-wasm/stream-compression. The test still creates a minimal ZIP with wp-content/index.php containing a marker string, but now delegates the ZIP format handling to the library code.
The test was using a fragile approach to remove auto-inserted brackets from CodeMirror's closeBrackets feature - pressing ArrowDown 4 times while holding Shift. This would fail if the number of auto-inserted characters changed. Now we select to end of document using Ctrl+Shift+End (or Meta+Shift+ArrowDown on Mac) which reliably selects any extra content regardless of how much was auto-inserted.
adamziel
added
[Type] Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR ensures that importing from GitHub or ZIP files always goes into a temporary Playground, protecting saved sites from accidental overwrite.
Test plan
?site-slug=<saved-site>(no temporary site exists)Two e2e tests have been added to verify this behavior automatically.