[1.20.1] Fix glowing feature#787
Open
FrozenGalaxy wants to merge 1 commit into
Open
Conversation
Persist GLOWING emission in BlockState and improve server-side light handling. Adds lightLevel and isValidSpawn callbacks to IFramedBlock so glowing framed blocks emit the configured glowstone level for vanilla light queries and prevent mob spawns when glowing. FramedBlockEntity: introduce scheduleLightUpdate (runs on the server thread), call updateDynamicStates and only send block updates when needed, and trigger scheduled light updates on state changes and onLoad. This fixes lighting inconsistencies across chunk reloads and reduces race conditions with the light engine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed glowing feature, it existed only via the block entity/dynamic Forge light path, not as a real blockstate/lightLevel so Minecrafts reload/chunk light engine didn’t reliably treat it as an actual light source.