refactor(core/txpool/legacypool): move queue out of main txpool #32270

[gzliudan]

Proposed changes

Extract future-queue state and operations from LegacyPool into a dedicated queue helper while preserving existing behavior.

• Move queued/beats management and queue operations (stats, content, add/remove, evict, promote, truncate) into queue.go.
• Update LegacyPool call sites to use queue helper methods instead of direct map access.
• Pass TRC21 fee capacity and current block number explicitly into queue promotion filtering.
• Keep queue-related metrics updates aligned, including queued and queued account gauges across add/remove/promote paths.
• Adapt legacypool tests to the new queue interface (queue.get / queue.addresses) without changing semantic expectations.

No functional change intended; this is a structural refactor to reduce complexity in the main txpool file.

Ref: ethereum#32270

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Changes that don't change source code or tests
• docs: Documentation only changes
• feat: A new feature
• fix: A bug fix
• perf: A code change that improves performance
• refactor: A code change that neither fixes a bug nor adds a feature
• revert: Revert something
• style: Changes that do not affect the meaning of the code
• test: Adding missing tests or correcting existing tests

Impacted Components

Which parts of the codebase does this PR touch?
Put an ✅ in the boxes that apply

• Consensus
• Account
• Network
• Geth
• Smart Contract
• External components
• Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

• This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
• Tested on a private network from the genesis block and monitored the chain operating correctly for multiple epochs.
• Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
• Tested the backwards compatibility.
• Tested with XDC nodes running this version co-exist with those running the previous version.
• Relevant documentation has been updated as part of this PR
• N/A

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 199d688e-fdb3-46d8-97bc-d72c87e1c8d4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR refactors the legacy txpool’s “future queue” by extracting queued transaction state and operations out of LegacyPool into a dedicated queue helper, aiming to reduce complexity while preserving behavior.

Changes:

• Introduces core/txpool/legacypool/queue.go to own queued/beats state and queue operations (evict/stats/content/promote/truncate).
• Updates LegacyPool to use the queue helper instead of directly manipulating queue/beat maps.
• Adapts legacy pool tests to the new queue structure and access patterns.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.

File	Description
core/txpool/legacypool/queue.go	Adds a new helper encapsulating queued tx state, promotion filtering, eviction, and truncation.
core/txpool/legacypool/legacypool.go	Rewires LegacyPool to use the queue helper; adjusts promotion and truncation flows accordingly.
core/txpool/legacypool/legacypool_test.go	Updates tests to reflect queue extraction and new access methods/structure.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.