fix(core/txpool/legacypool): fix pricedList updates #32906

[gzliudan]

Proposed changes

Ref: ethereum#32906

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Changes that don't change source code or tests
• docs: Documentation only changes
• feat: A new feature
• fix: A bug fix
• perf: A code change that improves performance
• refactor: A code change that neither fixes a bug nor adds a feature
• revert: Revert something
• style: Changes that do not affect the meaning of the code
• test: Adding missing tests or correcting existing tests

Impacted Components

Which parts of the codebase does this PR touch?
Put an ✅ in the boxes that apply

• Consensus
• Account
• Network
• Geth
• Smart Contract
• External components
• Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

• This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
• Tested on a private network from the genesis block and monitored the chain operating correctly for multiple epochs.
• Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
• Tested the backwards compatibility.
• Tested with XDC nodes running this version co-exist with those running the previous version.
• Relevant documentation has been updated as part of this PR
• N/A

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0e09c4ea-4d73-4384-a955-76a6d637ae8c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Refactors the legacy txpool’s “future/queued” transaction handling into a dedicated queue type and updates the pool’s removal paths to keep pricedList stale counters consistent (ref ethereum#32906).

Changes:

• Introduces core/txpool/legacypool/queue.go to encapsulate queued-tx bookkeeping (heartbeats, eviction, truncation, promotion).
• Updates LegacyPool to use the new queue type and ensures bulk removals update pool.priced.Removed(...) appropriately.
• Adjusts legacypool_test.go to use the new queue APIs.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
core/txpool/legacypool/queue.go	New queue abstraction for queued tx lifecycle operations (evict/promote/truncate) with metric updates.
core/txpool/legacypool/legacypool.go	Migrates LegacyPool from map-based queue/beats to *queue and fixes pricedList removal accounting.
core/txpool/legacypool/legacypool_test.go	Updates tests to use queue.get() / queue.addresses() instead of direct map access.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.