fix(core/txpool/legacypool): clarify and fix non-executable tx heartbeat #33704

[gzliudan]

Proposed changes

Ref: ethereum#33704

Types of changes

What types of changes does your code introduce to XDC network?
Put an ✅ in the boxes that apply

• build: Changes that affect the build system or external dependencies
• ci: Changes to CI configuration files and scripts
• chore: Changes that don't change source code or tests
• docs: Documentation only changes
• feat: A new feature
• fix: A bug fix
• perf: A code change that improves performance
• refactor: A code change that neither fixes a bug nor adds a feature
• revert: Revert something
• style: Changes that do not affect the meaning of the code
• test: Adding missing tests or correcting existing tests

Impacted Components

Which parts of the codebase does this PR touch?
Put an ✅ in the boxes that apply

• Consensus
• Account
• Network
• Geth
• Smart Contract
• External components
• Not sure (Please specify below)

Checklist

Put an ✅ in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

• This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
• Tested on a private network from the genesis block and monitored the chain operating correctly for multiple epochs.
• Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
• Tested the backwards compatibility.
• Tested with XDC nodes running this version co-exist with those running the previous version.
• Relevant documentation has been updated as part of this PR
• N/A

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6de1f3b1-6e8d-4f4c-a6b7-162470a6d9dd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR adjusts how the legacy txpool’s non-executable (queued) transaction “heartbeat” is tracked, preventing heartbeats from being created/updated for accounts that don’t currently have queued transactions and clarifying related semantics in comments.

Changes:

• Make queue.bump a no-op for unknown addresses (only updates heartbeat for accounts already tracked in beats).
• Clarify Config.Lifetime meaning as “staleness” time for queued accounts (not per-tx lifetime).
• Update/clarify comments around when queued heartbeats are bumped during replacement/promotion.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
core/txpool/legacypool/queue.go	Changes bump to only update existing heartbeats, avoiding seeding beats for accounts without queued txs.
core/txpool/legacypool/legacypool.go	Comment clarifications for Lifetime and for heartbeat bumping during tx replacement/promotion.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Consider adding a regression test for the fixed heartbeat behavior: when queue.bump(addr) is called for an address with no queued txs, it should not pre-create a heartbeat that later prevents queue.add from initializing a fresh heartbeat. Without a test, it’s easy to reintroduce the bug where newly-queued txs can be treated as immediately stale because an old beats[addr] already exists.