fix(action): forward AWS credentials into the build container - #57
Merged
Merged
Conversation
The action runs netdocs inside a container and passed through only HOME, so any plugin reaching AWS during the build had no credentials to resolve, however the surrounding workflow had configured them. An imported-docs S3 source failed with 'Failed to resolve AWS credentials' even directly after aws-actions/configure-aws-credentials succeeded. Standard AWS_* variables present on the runner are now forwarded, and a web-identity token file is mounted and re-pointed at its in-container path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The action runs netdocs inside a container and passed through only HOME, so any plugin reaching AWS during the build had no credentials to resolve, however the surrounding workflow had configured them. An imported-docs S3 source failed with 'Failed to resolve AWS credentials' even directly after aws-actions/configure-aws-credentials succeeded.
Standard AWS_* variables present on the runner are now forwarded, and a web-identity token file is mounted and re-pointed at its in-container path.
What & why
Type of change
Checklist
dotnet format Netdocs.slnx --verify-no-changespassesdotnet build Netdocs.slnx -c Releasesucceedsdotnet test Netdocs.slnx -c Releasepassesdocs-site/docs/**if behavior changedNotes for reviewers