Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Walkthrough홈 네비게이션을 문자열 기반에서 타입 안전 방식으로 전환하고, NavController 기반 제어를 상태/콜백 기반 API로 바꿨습니다. HomeRoute를 직렬화 가능한 봉인 인터페이스로 재구성하고, Navigator와 BottomBar/Host 간 인터페이스를 타입 안전한 HomeRoute로 연결했습니다. Changes
Sequence Diagram(s)sequenceDiagram
participant User as "사용자(UI)"
participant BottomBar as "HomeBottomNavigationBar"
participant Navigator as "HomeNavigator"
participant NavCtrl as "NavController / NavHost"
User->>BottomBar: 탭 선택 (HomeRoute)
BottomBar->>Navigator: onTabSelected(HomeRoute)
Navigator->>NavCtrl: navigateTo(HomeRoute) (popUpTo clear)
NavCtrl->>NavCtrl: 현재 destination 업데이트
NavCtrl->>Navigator: destination 변경 반영 (currentHomeRoute)
Navigator-->>BottomBar: selectedTab 업데이트 (state)
BottomBar-->>User: 선택된 탭 반영 UI 갱신
Estimated code review effort🎯 3 (보통) | ⏱️ ~20분 개요홈 네비게이션 로직을 문자열 기반에서 타입 안전 방식으로 변경했습니다. 변경 사항
코드 리뷰 추정 난이도🎯 3 (보통) | ⏱️ ~20분 토끼의 축하 시
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
app/src/main/java/com/threegap/bitnagil/navigation/home/HomeBottomNavigationBar.kt (1)
47-54: 현재 탭 재선택 이벤트는 가드하는 것을 권장합니다.Line 53에서 선택된 탭에도 콜백이 발생해 불필요한 네비게이션 호출이 생길 수 있습니다.
♻️ 제안 수정안
homeTabList.forEach { homeTab -> HomeBottomNavigationItem( modifier = Modifier.weight(1f), icon = homeTab.icon, title = homeTab.title, selected = selectedTab == homeTab.route, - onClick = { onTabSelected(homeTab.route) }, + onClick = { + if (selectedTab != homeTab.route) { + onTabSelected(homeTab.route) + } + }, ) }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@app/src/main/java/com/threegap/bitnagil/navigation/home/HomeBottomNavigationBar.kt` around lines 47 - 54, 현재 선택된 탭을 다시 누를 때 불필요한 네비게이션 콜백이 발생하므로 HomeBottomNavigationItem의 onClick에서 selectedTab과 homeTab.route를 비교해 같으면 onTabSelected를 호출하지 않도록 가드하세요; 구체적으로 homeTabList.forEach 블록의 HomeBottomNavigationItem(onClick = { ... }) 내부에서 selectedTab != homeTab.route 조건을 확인하고 참일 때만 onTabSelected(homeTab.route)를 호출하도록 변경하십시오.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@app/src/main/java/com/threegap/bitnagil/navigation/home/HomeNavigator.kt`:
- Around line 33-36: The navigateTo implementation in HomeNavigator uses
popUpTo(0) which clears the entire back stack and loses UI state; update
navigateTo(navController.navigate(route) { ... }) to pop up to the start
destination ID instead (use navController.graph.findStartDestination().id),
enable saveState = true inside the popUpTo block, and also set launchSingleTop =
true and restoreState = true to preserve and restore tab state (scroll/input)
when switching HomeRoute tabs.
---
Nitpick comments:
In
`@app/src/main/java/com/threegap/bitnagil/navigation/home/HomeBottomNavigationBar.kt`:
- Around line 47-54: 현재 선택된 탭을 다시 누를 때 불필요한 네비게이션 콜백이 발생하므로
HomeBottomNavigationItem의 onClick에서 selectedTab과 homeTab.route를 비교해 같으면
onTabSelected를 호출하지 않도록 가드하세요; 구체적으로 homeTabList.forEach 블록의
HomeBottomNavigationItem(onClick = { ... }) 내부에서 selectedTab != homeTab.route
조건을 확인하고 참일 때만 onTabSelected(homeTab.route)를 호출하도록 변경하십시오.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f4416fe4-3131-40a3-be95-5426e6e9b56e
📒 Files selected for processing (4)
app/src/main/java/com/threegap/bitnagil/navigation/home/HomeBottomNavigationBar.ktapp/src/main/java/com/threegap/bitnagil/navigation/home/HomeNavHost.ktapp/src/main/java/com/threegap/bitnagil/navigation/home/HomeNavigator.ktapp/src/main/java/com/threegap/bitnagil/navigation/home/HomeRoute.kt
app/src/main/java/com/threegap/bitnagil/navigation/home/HomeNavigator.kt
Show resolved
Hide resolved
l5x5l
reviewed
Mar 29, 2026
app/src/main/java/com/threegap/bitnagil/navigation/home/HomeNavigator.kt
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ PR Content ]
homeRoute 부분에 사용중이던 String 방식을 제거하고 type-safe 방식으로 통일했습니다.
Related issue
Screenshot 📸
Work Description
To Reviewers 📢
Summary by CodeRabbit
릴리스 노트