Fix macOS collector Tk crash and clarify Apple silicon setup#2
Open
ZhiyuanMa2017 wants to merge 1 commit intoZdong104:mainfrom
Open
Fix macOS collector Tk crash and clarify Apple silicon setup#2ZhiyuanMa2017 wants to merge 1 commit intoZdong104:mainfrom
ZhiyuanMa2017 wants to merge 1 commit intoZdong104:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the macOS collector flow in two ways:
tkintermay be missing unless the matching Tk package is installed.What Changed
Code
Docs
brew install python-tk@3.14Why
On macOS, the collector was crashing at startup with:
This came from the Tk overlay and dialog flow being created from a background thread.
Before that, on Homebrew Python 3.14,
tkinterwas also missing until the matching Tk package was installed:Result
Notes
to the terminal app they use to launch the collector.
Better test this change on windows and linux before merge.