Merged
Conversation
…libaba#223) * fix: id mismatch * fix: remove debug string * fix: use protected * chore(comment): add comments * feat: more ut * Update vector_recall_test.cc * fix: resolve comments
* fix: fix mips euclidean
## Summary - set close-on-exec for file open/create paths to prevent lock FD inheritance across exec - add `zvec_open_read_only(const char* path, zvec_collection_t* out)` C API and open collection with `read_only_=true` - add regression tests for CLOEXEC behavior and lock FD inheritance across fork+exec - fix the lock-inheritance regression test to move ownership from the create result and avoid shared ownership false negatives ## Testing - `./build-1349/bin/file_test --gtest_filter=File.CreateAndOpen_SetsCloseOnExecFlag` - `./build-1349/bin/collection_test --gtest_filter=CollectionTest.Feature_LockFdIsNotInheritedAcrossExec`
zackarychapple
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebase
ZephyrCloudIO/zvecmainontoalibaba/main(3c1241f), then re-apply Zephyr-only commits on top.Upstream commits included (from
alibaba/main)9314cb1fix: use per-block filter instead of per-segment filter during query (fix: use per-block filter instead of per-segment filter during query alibaba/zvec#223)65b4547fix: minor typo (fix: minor typo alibaba/zvec#225)de1e705fix/fix mips euclidean (fix/fix mips euclidean alibaba/zvec#226)7bc4838feat: buildwheel in ghrunner (feat: buildwheel in ghrunner alibaba/zvec#221)5124fbcminor: add deepwiki badges (minor: add badges alibaba/zvec#228)3c1241ffeat: enlarge indice size limit for sparse vectors (feat: enlarge indice size limit for sparse vectors alibaba/zvec#229)Zephyr commits re-applied
7c1d9a0chore: Add C bindings (chore: Add C bindings #1)0a4f67efix(locking): prevent lock fd inheritance and add read-only C open (fix(locking): prevent lock fd inheritance and add read-only C open #2)Commit mapping (same patch, new SHA)
5d6ff10=>7c1d9a0b8ef57d=>0a4f67eSafety / rollback
backup/kdy1-main-before-rebase-20260317maintip:01a57baReviewer notes
This PR primarily aligns history with upstream and brings in upstream changes. Please focus review on integration points and CI stability.