PREAPPS-9206 Resolve Base Path Handling – Upgrade preact-router#324
Merged
Conversation
silentsakky
reviewed
May 12, 2026
| "preact-i18n": "^2.4.0-preactx", | ||
| "preact-render-to-string": "^5.2.0", | ||
| "preact-router": "github:zimbra/preact-router#3.1.1_base_path_support", | ||
| "preact-router": "github:zimbra/preact-router#PREAPPS-9206", |
Member
There was a problem hiding this comment.
this might be temporary but we should use proper branch names when merging the changes to master
something like 4.1.2_base_path_support
silentsakky
approved these changes
May 12, 2026
damini-vashishtha
force-pushed
the
PREAPPS-9206
branch
from
93d92da to
e769da9
Compare
lavegupta
approved these changes
May 18, 2026
miteshsavani810
approved these changes
May 18, 2026
damini-vashishtha
force-pushed
the
PREAPPS-9206
branch
from
e769da9 to
b7d7f29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.